Rename config for enabling CentralizedDatasourceSchema feature #15476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ruid.centralizedTableSchema.enabled
findingrish
changed the title
cryptoe
reviewed
Dec 4, 2023
docs/configuration/index.md
Outdated
| @@ -876,7 +876,7 @@ These Coordinator static configurations can be defined in the `coordinator/runti | |||
| |`druid.coordinator.loadqueuepeon.repeatDelay`|The start and repeat delay for the `loadqueuepeon`, which manages the load and drop of segments.|`PT0.050S` (50 ms)| | |||
| |`druid.coordinator.asOverlord.enabled`|Boolean value for whether this Coordinator service should act like an Overlord as well. This configuration allows users to simplify a Druid cluster by not having to deploy any standalone Overlord services. If set to true, then Overlord console is available at `http://coordinator-host:port/console.html` and be sure to set `druid.coordinator.asOverlord.overlordService` also.|false| | |||
| |`druid.coordinator.asOverlord.overlordService`| Required, if `druid.coordinator.asOverlord.enabled` is `true`. This must be same value as `druid.service` on standalone Overlord services and `druid.selectors.indexing.serviceName` on Middle Managers.|NULL| | |||
| |`druid.coordinator.centralizedTableSchema.enabled`|Boolean flag for enabling table schema building on the Coordinator.|false| | |||
| |`druid.centralizedTableSchema.enabled`|Boolean flag for enabling table schema building on the Coordinator.|false| | |||
There was a problem hiding this comment.
Suggested change
| |`druid.centralizedTableSchema.enabled`|Boolean flag for enabling table schema building on the Coordinator.|false| | |
| |`druid.centralizedDataSourceSchema.enabled`|Boolean flag for enabling data source schema building on the Coordinator.|false| |
Druid users understand data sources better.
findingrish
changed the title
cryptoe
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14989
This property was originally added in #14985 with the name
druid.coordinator.centralizedTableSchema.enabled.However, this config isn't specific to Coordinator and will be used in different services Indexer/Peons (#15475), Coordinator.
So, it is being renamed to
druid.centralizedDatasourceSchema.enabled(since in Druid we use the termDatasourceinstead ofTable).