docs: blurb about msq union all #15223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LakshSingla
reviewed
Oct 23, 2023
docs/querying/sql.md
Outdated
| Keep the following in mind when writing top-level UNION ALL queries: | ||
|
|
||
| - You can't apply GROUP BY, ORDER BY, or any other operator to the results of a UNION ALL. | ||
| - If you use the MSQ task engine for the query, the SQL planner attempts to plan the top-level UNION ALL as a table-level UNION ALL. Because of this, the query behaves the same as a table-level UNION ALL, meaning it has the same characteristics and limitations. If the planner can't plan the query as a table-level UNION ALL, the query fails. |
There was a problem hiding this comment.
Suggested change
| - If you use the MSQ task engine for the query, the SQL planner attempts to plan the top-level UNION ALL as a table-level UNION ALL. Because of this, the query behaves the same as a table-level UNION ALL, meaning it has the same characteristics and limitations. If the planner can't plan the query as a table-level UNION ALL, the query fails. | |
| - If you use the MSQ task engine for the query, the SQL planner attempts to plan the top-level UNION ALL as a table-level UNION ALL. Therefore it has the same limitations as the table level union all - You can only union TableDataSources with simple projections - select columns and rename columns. Clauses like GROUP BY, ORDER BY, etc are not supported on operands of union. | |
| The query isn't supported if the planner can't plan it as a table-level union all |
docs/querying/sql.md
Outdated
| ::: | ||
| Keep the following in mind when writing top-level UNION ALL queries: | ||
|
|
||
| - You can't apply GROUP BY, ORDER BY, or any other operator to the results of a UNION ALL. |
There was a problem hiding this comment.
Can coalesce into a single paragraph as mentioned in the other comment
Suggested change
| - You can't apply GROUP BY, ORDER BY, or any other operator to the results of a UNION ALL. |
There was a problem hiding this comment.
This limitation predates my changes and seems to apply to any query engine. So does it no longer apply to non-MSQ queries?
There was a problem hiding this comment.
This limitation is still present, but as per the previous comment, we can make it cohesive by coalescing both of the limitations into one big para.
There was a problem hiding this comment.
Ok, if we want it in 1 paragraph, I'll need to rewrite the paragraph first. Starting with If you use the MSQ task engine for the query, sets the reader up to think that the whole paragraph is only about the MSQ task engine limitations
There was a problem hiding this comment.
9ab4130 has the new paragraph
ektravel
reviewed
Oct 27, 2023
ektravel
approved these changes
Oct 27, 2023
Co-authored-by: Katya Macedo <[email protected]>
LakshSingla
approved these changes
Oct 31, 2023
317brian
added a commit
to 317brian/druid
that referenced
this pull request
Oct 31, 2023
(cherry picked from commit 8769541)
1 task
CaseyPan
pushed a commit
to CaseyPan/druid
that referenced
this pull request
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a blurb about how MSQ treats UNION ALL queries
This PR has: