fix incorrect unnest dimension cursor value matcher implementation #15192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area - Segment Format and Ser/De
and removed
Area - Querying
labels
soumyava
approved these changes
Oct 18, 2023
| .addOrderByColumn("alias0", OrderByColumnSpec.Direction.ASCENDING) | ||
| .build(); | ||
|
|
||
| // Total rows should add up to 26 * 2 = 52 |
There was a problem hiding this comment.
nit. this comment is not relevant here
| .addOrderByColumn("alias0", OrderByColumnSpec.Direction.ASCENDING) | ||
| .build(); | ||
|
|
||
| // Total rows should add up to 26 * 2 = 52 |
There was a problem hiding this comment.
nit. there are 52 values as filter is on non existent value
There was a problem hiding this comment.
oops, i copied this whole test from another test and just added filters, will just remove
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Oct 18, 2023
LakshSingla
pushed a commit
that referenced
this pull request
Oct 19, 2023
CaseyPan
pushed a commit
to CaseyPan/druid
that referenced
this pull request
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue from #15058 with value matchers created by
UnnestDimensionCursorfor matches against non-existent values, which I forgot to update to match only null rows wheneverincludeUnknownis set to true. I checked around and didn't notice any other implementations with this issue, the problem was that it was treating the case as a non-existent column instead of an always false matcher that should only match null rows whenincludeUnknownis true, and so instead would effectively match nothing when used with a not filter. Added tests cover the case.This PR has: