Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DESC ordering in window expressions #15185

Closed
wants to merge 113 commits into from
Closed

Allow DESC ordering in window expressions #15185

wants to merge 113 commits into from

Conversation

kgyrtkirk
Copy link
Member

  • allow DESC ordering in window expressions
  • also allow and accept NULLS FIRST / NULLS LAST options if they align with the actual ordering mode
    • report if they are unsupported

includes: #15119 #15148

kgyrtkirk added 30 commits October 4, 2023 09:49
@kgyrtkirk
fixes
bd55afd
@kgyrtkirk
check for latest rewrite place
5cf1e2c
@kgyrtkirk
Revert "check for latest rewrite place"
c4ff274 
This reverts commit 5cf1e2c.
@kgyrtkirk
some stuff
89844e9 
(cherry picked from commit ab346d4373ea888eb8ef6115e018e7fb0d27407f)
@kgyrtkirk
update test output
ed5d100
@kgyrtkirk
updates to test ouptuts
2a4a3ab
@kgyrtkirk
some stuff
02aac9d
@kgyrtkirk
move validator
a9877c4
@kgyrtkirk
cleanup
f104ce4
@kgyrtkirk
fix
145fe82
@kgyrtkirk
change test slightly
761cd68
@kgyrtkirk
add apidoc cleanup warnings
a10fe7a
@kgyrtkirk
cleanup/etc
6082df5
@kgyrtkirk
instead of telling the story; add a fail with some reason whats the i…
34a6aeb 
…ssue
@kgyrtkirk
Merge remote-tracking branch 'apache/master' into windowing-fix-test-cmp
9b74ef5
@kgyrtkirk
lead-lag fix
e376ae9
@kgyrtkirk
add test
1acd53b
@kgyrtkirk
remove unnecessary throw
a708ef2
@kgyrtkirk
druidexception-trial
8fa0664
@kgyrtkirk
Revert "druidexception-trial"
b484606 
This reverts commit 8fa0664.
@kgyrtkirk
undo changes to no_grouping; add no_grouping2
2858ff6
@kgyrtkirk
Merge remote-tracking branch 'apache/master' into windowing-fix-test-cmp
2e91d7c
@kgyrtkirk
add missing assert on resultcount
9a80c89
@kgyrtkirk
rename method; update
ee2b35d
@kgyrtkirk
introduce enum/etc
4e216b7
@kgyrtkirk
make resultmatchmode accessible from TestBuilder#expectedResults
5d0fcc0
@kgyrtkirk
fix dump results to use log
0ddd3be
@kgyrtkirk
Merge remote-tracking branch 'apache/master' into windowing-fix-test-cmp
4073f5e
@kgyrtkirk
Merge remote-tracking branch 'apache/master' into windowing-fix-test-cmp
47e81d8
@kgyrtkirk
fix
edea152
@kgyrtkirk
Merge branch 'drill-parq-json' into windowing-fixes-string-min-max
0355d8a
@kgyrtkirk
fix time/long
f9493f8
@kgyrtkirk
try nulls first/last
8d28b75
@kgyrtkirk
change order in file
41239d1
@kgyrtkirk
Merge remote-tracking branch 'apache/master' into drill-parq-json
26807c0
@kgyrtkirk
fixed by null+this
c330f6c
@kgyrtkirk
private const
0d7309e
@kgyrtkirk
Merge branch 'drill-parq-json' into windowing-desc-stuff
6897e93
@kgyrtkirk
fix/changes/etc
8fa322e
@kgyrtkirk
fixes/etc
ddceef6
@kgyrtkirk
better stuff
d37093e
@kgyrtkirk
move around
c0d3095
@kgyrtkirk
add tests; move check to sqloperator
cff9109
@kgyrtkirk
accept passing testcases
fca23c2
@kgyrtkirk
move back to use validator
71d25d8
@kgyrtkirk
accept passing cases/etc
0936b3a
@kgyrtkirk
add Windowing level fix
15bf039
@kgyrtkirk
purge out virtualColumns param
4d83905
@kgyrtkirk
working
a218b3c
@kgyrtkirk
cleanup/etc
9bf2c37
@kgyrtkirk
cleanup
b034474
@kgyrtkirk
checkstyle fixes
e1f7ef5
@kgyrtkirk
remove VCR arg
87c6063
@kgyrtkirk
add assert
43df657
@kgyrtkirk
Merge branch 'windowing-fixes-string-min-max' into windowing-desc-stuff
3154922
@kgyrtkirk kgyrtkirk closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area - Dependencies Area - Querying Area - Segment Format and Ser/De
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kgyrtkirk