fix issue with SQL boolean constants not respecting nulls when strict booleans and sql compatible null handling are enabled #15135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… booleans are enabled
LakshSingla
approved these changes
Oct 11, 2023
clintropolis
changed the title
|
ci failure related to coverage in default value mode (since the new code only applies in sql compatible mode) |
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Oct 13, 2023
… booleans and sql compatible null handling are enabled (apache#15135)
ektravel
pushed a commit
to ektravel/druid
that referenced
this pull request
Oct 16, 2023
… booleans and sql compatible null handling are enabled (apache#15135)
CaseyPan
pushed a commit
to CaseyPan/druid
that referenced
this pull request
Nov 17, 2023
… booleans and sql compatible null handling are enabled (apache#15135)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue semi related to #15058, but this dealing specifically with boolean constant expressions, where boolean constants in the SQL layer were effectively not allowed to be null.
The result was incorrect behavior from a query like:
even if
druid.expressions.useStrictBooleanswas set to true anddruid.generic.useDefaultValueForNullset to false. I've modifiedDruidLogicalValuesRuleto check for null values on BOOLEAN types, but only ifdruid.expressions.useStrictBooleans=trueanddruid.generic.useDefaultValueForNull=false, resulting in the previous query now producing correct results:This PR has: