-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: durable storage azure cleanup #15120
Conversation
Many comments address inconsistencies in the docs that were already present and not introduced by the PR, but it would be nice to clean them up regardless. |
Co-authored-by: Laksh Singla <[email protected]>
I manually made the changes in 7c4c68e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
A minor comment - we should not mention "intermediate files" everywhere. Perhaps temporary files or just files should be fine enough.
Co-authored-by: Laksh Singla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a nit, but it isn't a deal breaker.
docs/multi-stage-query/security.md
Outdated
- `Microsoft.Storage/storageAccounts/blobServices/containers/blobs/write` to write the files in durable storage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nit: "the files" is used in these two sentences, while the rest omit the use of the article. Similarly in the block above
Co-authored-by: Laksh Singla <[email protected]> (cherry picked from commit 436ded3)
Co-authored-by: Laksh Singla <[email protected]>
Co-authored-by: Laksh Singla <[email protected]>
Description
Copyedit the docs related to Azure + MSQ durable storage
Release note
n/a
This PR has: