Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: durable storage azure cleanup #15120

Merged
merged 10 commits into from
Oct 31, 2023
Merged

Conversation

317brian
Copy link
Contributor

Description

Copyedit the docs related to Azure + MSQ durable storage

Release note

n/a


This PR has:

  • been self-reviewed.

@317brian 317brian requested a review from LakshSingla October 10, 2023 17:22
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 17, 2023
docs/multi-stage-query/reference.md Show resolved Hide resolved
docs/multi-stage-query/reference.md Outdated Show resolved Hide resolved
docs/multi-stage-query/reference.md Outdated Show resolved Hide resolved
docs/multi-stage-query/security.md Outdated Show resolved Hide resolved
docs/multi-stage-query/security.md Outdated Show resolved Hide resolved
docs/multi-stage-query/security.md Outdated Show resolved Hide resolved
docs/multi-stage-query/reference.md Show resolved Hide resolved
@LakshSingla
Copy link
Contributor

Many comments address inconsistencies in the docs that were already present and not introduced by the PR, but it would be nice to clean them up regardless.

@317brian
Copy link
Contributor Author

I manually made the changes in 7c4c68e

@317brian 317brian requested a review from LakshSingla October 17, 2023 23:39
Copy link
Contributor

@LakshSingla LakshSingla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.
A minor comment - we should not mention "intermediate files" everywhere. Perhaps temporary files or just files should be fine enough.

docs/multi-stage-query/security.md Outdated Show resolved Hide resolved
docs/multi-stage-query/security.md Outdated Show resolved Hide resolved
@317brian 317brian requested a review from LakshSingla October 26, 2023 21:25
Copy link
Contributor

@LakshSingla LakshSingla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a nit, but it isn't a deal breaker.

Comment on lines 80 to 81
- `Microsoft.Storage/storageAccounts/blobServices/containers/blobs/write` to write the files in durable storage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: "the files" is used in these two sentences, while the rest omit the use of the article. Similarly in the block above

@317brian 317brian merged commit 436ded3 into apache:master Oct 31, 2023
11 checks passed
317brian added a commit to 317brian/druid that referenced this pull request Oct 31, 2023
Co-authored-by: Laksh Singla <[email protected]>
(cherry picked from commit 436ded3)
techdocsmith pushed a commit that referenced this pull request Nov 1, 2023
CaseyPan pushed a commit to CaseyPan/druid that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants