Added UI support for waitTillSegmentsLoad #15110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorem--ipsum
force-pushed
the
waitTillSegmentsLoad-ui
branch
from
a00c515 to
0635acc
Compare
| public getSegmentStatusDescription() { | ||
| const { segmentStatus } = this; | ||
|
|
||
| switch (segmentStatus) { |
There was a problem hiding this comment.
Could this also display the segments breakdown after ingestion? This information should be available in the same place
"totalSegments": 1,
"usedSegments": 1,
"precachedSegments": 0,
"onDemandSegments": 0,
There was a problem hiding this comment.
We should also show the time for the query part and ingestion part separately, so that any user can know the actual time taken for the query and won't mistake it as druid being slow. This information should also be available in segmentLoadStatus and its parent object.
|
I think we should also disable the current sql check, since it would be no longer needed |
|
Thanks for the feedback, I've added mroe details in the "Details" dialog: |
adarshsanjeev
approved these changes
Oct 11, 2023
LakshSingla
pushed a commit
to LakshSingla/druid
that referenced
this pull request
Oct 14, 2023
This relies on the work done in apache#14322 and apache#15076. It allows the user to set waitTillSegmentsLoad in the query context (if they want, else it defaults to true) and shows the results in the UI :
LakshSingla
added a commit
that referenced
this pull request
Oct 16, 2023
This relies on the work done in #14322 and #15076. It allows the user to set waitTillSegmentsLoad in the query context (if they want, else it defaults to true) and shows the results in the UI : Co-authored-by: Sébastien <[email protected]>
ektravel
pushed a commit
to ektravel/druid
that referenced
this pull request
Oct 16, 2023
This relies on the work done in apache#14322 and apache#15076. It allows the user to set waitTillSegmentsLoad in the query context (if they want, else it defaults to true) and shows the results in the UI :
CaseyPan
pushed a commit
to CaseyPan/druid
that referenced
this pull request
Nov 17, 2023
This relies on the work done in apache#14322 and apache#15076. It allows the user to set waitTillSegmentsLoad in the query context (if they want, else it defaults to true) and shows the results in the UI :
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on the work done in #14322 and #15076. It allows the user to set
waitTillSegmentsLoadin the query context (if they want, else it defaults totrue) and shows the results in the UI :