Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run build and unit tests using Java 21 #15088

Merged
merged 5 commits into from
Oct 6, 2023
Merged

run build and unit tests using Java 21 #15088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
23f8699
run build and unit test using Java 21
xvrl Oct 4, 2023
516c442
run static checks with Java 21
xvrl Oct 4, 2023
aef25f1
use setup-java for unit tests, since Java 21 is not built-in
xvrl Oct 4, 2023
d7deb52
skip maven cache from setup-java
xvrl Oct 5, 2023
0d1256b
add comments to explain cache behavior
xvrl Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/reusable-unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,15 @@ jobs:
with:
fetch-depth: 0

- name: setup jdk${{ inputs.jdk }}
run: echo "JAVA_HOME=$JAVA_HOME_${{ inputs.jdk }}_X64" >> $GITHUB_ENV
# skip the "cache: maven" step from setup-java. We explicitly use a
# different cache key since we cannot reuse it across commits.
- uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: ${{ inputs.jdk }}

# the build step produces SNAPSHOT artifacts into the local maven repository,
# we include github.sha in the cache key to make it specific to that build/jdk
- name: Restore Maven repository
id: maven-restore
uses: actions/cache/restore@v3
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/standard-its.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ jobs:
- name: Setup java
run: export JAVA_HOME=$JAVA_HOME_8_X64

# the build step produces SNAPSHOT artifacts into the local maven repository,
# we include github.sha in the cache key to make it specific to that build/jdk
- name: Restore Maven repository
id: maven-restore
uses: actions/cache/restore@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/static-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ '8', '11', '17' ]
java: [ '8', '11', '17', '21' ]
runs-on: ubuntu-latest
steps:
- name: checkout branch
Expand Down
15 changes: 10 additions & 5 deletions .github/workflows/unit-and-integration-tests-unified.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,21 @@ jobs:
strategy:
fail-fast: false
matrix:
jdk: [ '8', '11', '17' ]
jdk: [ '8', '11', '17', '21' ]
runs-on: ubuntu-latest
steps:
- name: Checkout branch
uses: actions/checkout@v3

- name: setup jdk${{ matrix.jdk }}
run: |
echo "JAVA_HOME=$JAVA_HOME_${{ matrix.jdk }}_X64" >> $GITHUB_ENV
# skip the "cache: maven" step from setup-java. We explicitly use a
# different cache key since we cannot reuse it across commits.
- uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: ${{ matrix.jdk }}

# the build step produces SNAPSHOT artifacts into the local maven repository,
# we include github.sha in the cache key to make it specific to that build/jdk
- name: Cache Maven m2 repository
id: maven
uses: actions/cache@v3
Expand Down Expand Up @@ -112,7 +117,7 @@ jobs:
strategy:
fail-fast: false
matrix:
jdk: [ 11, 17 ]
jdk: [ 11, 17, 21 ]
name: "unit tests (jdk${{ matrix.jdk }}, sql-compat=true)"
uses: ./.github/workflows/unit-tests.yml
needs: unit-tests
Expand Down