Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CalciteSysQueryTest to enable some testing of bindable plans. #15070

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

kgyrtkirk
Copy link
Member

@kgyrtkirk kgyrtkirk commented Oct 3, 2023

Fixes #XXXX.

Description

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.

@kgyrtkirk kgyrtkirk marked this pull request as ready for review October 3, 2023 20:19
Copy link
Contributor

@somu-imply somu-imply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for logging the logical plan. This will be helpful! LGTM

@soumyava soumyava merged commit 36d7b3c into apache:master Oct 5, 2023
74 checks passed
@xvrl
Copy link
Member

xvrl commented Oct 5, 2023

@soumyava @kgyrtkirk @somu-imply it looks like this commit broke the build notMsqCompatible is not defined anywhere. Can we please revert this until this is fixed?

@xvrl
Copy link
Member

xvrl commented Oct 5, 2023

looks like the function was renamed in #14900

@somu-imply somu-imply mentioned this pull request Oct 5, 2023
10 tasks
@somu-imply
Copy link
Contributor

somu-imply commented Oct 5, 2023

@xvrl Yes this is being fixed in #15099. Will merge as soon as CI passes

@soumyava
Copy link
Contributor

soumyava commented Oct 6, 2023

The master should be back up as the PR is merged

@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants