urlencode nested serializer temp file names so they dont explode stuff #15068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekagarwal87
approved these changes
Oct 3, 2023
kgyrtkirk
reviewed
Oct 3, 2023
| @@ -135,7 +135,9 @@ public int lookupString(@Nullable String value) | |||
| public int lookupLong(@Nullable Long value) | |||
| { | |||
| if (longDictionary == null) { | |||
| Path longFile = makeTempFile(name + NestedCommonFormatColumnSerializer.LONG_DICTIONARY_FILE_NAME); | |||
| final Path longFile = makeTempFile( | |||
There was a problem hiding this comment.
note: seems like makeTempFile is a class method; it could be possible to push the StringUtils.urlEncode(name) into that; so that call sites could look like:
makeTempFile(NestedCommonFormatColumnSerializer.LONG_DICTIONARY_FILE_NAME)
the method already appends .tmp ; so it could pick up this as well
There was a problem hiding this comment.
I was thinking of that too but if we are doing that, we should change the name of the method so that encoding is not done twice?
ektravel
pushed a commit
to ektravel/druid
that referenced
this pull request
Oct 16, 2023
apache#15068) Fixes a bug caused by apache#14919, which was just using the column name as part of a temp file name, which.. isn't very cool, my bad. Switched to use StringUtils.urlEncode so that ugly chars don't explode stuff. The modified test fails without the changes in this PR.
CaseyPan
pushed a commit
to CaseyPan/druid
that referenced
this pull request
Nov 17, 2023
apache#15068) Fixes a bug caused by apache#14919, which was just using the column name as part of a temp file name, which.. isn't very cool, my bad. Switched to use StringUtils.urlEncode so that ugly chars don't explode stuff. The modified test fails without the changes in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug caused by #14919, which was just using the column name as part of a temp file name, which.. isn't very cool, my bad. Switched to use
StringUtils.urlEncodeso that ugly chars don't explode stuff. The modified test fails without the changes in this PR.This PR has: