Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup the maximum concurrent queries in Druid used for calculation in ClientQuerySegmentWalker #15017

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

LakshSingla
Copy link
Contributor

Description

#14808 introduced auto mode for calculating the size to be reserved for inlining the subquery results per query, however, I incorrectly used druid.broker.http.numConnections as the maximum number of queries that the broker can serve concurrently instead of druid.server.http.numThreads. The former refers to the connections per query that the broker can use to contact data nodes, whereas the latter refers to the number of threads in the broker reserved for serving the queries (which represents the correct figure).

This PR corrects that patch.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@gianm
Copy link
Contributor

gianm commented Sep 20, 2023

Everything passed except for an IT that has been problematic lately in other PRs as well. So I'll merge this. Thanks @LakshSingla!

@gianm gianm merged commit 82e809c into apache:master Sep 20, 2023
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants