Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AbstractQueryResourceTestClient to handle retry server errors #15016

Closed
wants to merge 10 commits into from
Closed

Fix AbstractQueryResourceTestClient to handle retry server errors #15016

wants to merge 10 commits into from

Conversation

kgyrtkirk
Copy link
Member

@kgyrtkirk kgyrtkirk commented Sep 20, 2023 •
edited
Loading

AbstractQueryResourceTestClient is failing in some cases because its not retrying in case it recieves 500/internal server error(s)

2023-09-20T08:16:04.6503559Z java.lang.RuntimeException: org.apache.druid.java.util.common.ISE: Error while querying[https://127.0.0.1:8282/druid/v2?pretty] status[500 Server Error] content[:)
2023-09-20T08:16:04.6534654Z ^E��errorPUnknown exception�errorClassgorg.jboss.netty.channel.ChannelException�hostTdruid-historical:8283�errorCodeSlegacyQueryException�personaGOPERATOR�categoryNRUNTIME_FAILURE�er
rorMessageSChannel disconnected�context�BTdruid-historical:8283Agorg.jboss.netty.channel.ChannelException�legacyErrorCodePUnknown exception��]
2023-09-20T08:16:04.6537569Z    at org.apache.druid.testing.clients.AbstractQueryResourceTestClient.query(AbstractQueryResourceTestClient.java:202) ~
[...]
2023-09-20T08:16:04.6622744Z Caused by: org.apache.druid.java.util.common.ISE: Error while querying[https://127.0.0.1:8282/druid/v2?pretty] status[500 Server Error] content[:)
2023-09-20T08:16:04.6624221Z ^E��errorPUnknown exception�errorClassgorg.jboss.netty.channel.ChannelException�hostTdruid-historical:8283�errorCodeSlegacyQueryException�personaGOPERATOR�categoryNRUNTIME_FAILURE�errorMessageSChannel disconnected�context�BTdruid-historical:8283Agorg.jboss.netty.channel.ChannelException�legacyErrorCodePUnknown exception��]
2023-09-20T08:16:04.6625878Z    at org.apache.druid.testing.clients.AbstractQueryResourceTestClient.query(AbstractQueryResourceTestClient.java:186) ~[druid-integration-tests-28.0.0-SNAPSHOT.jar:28.0.0-SNAPSHOT]
2023-09-20T08:16:04.6626509Z    ... 38 more

@kgyrtkirk kgyrtkirk changed the title Try to fix flaky integration tests Fix AbstractQueryResourceTestClient to handle retry server errors Sep 20, 2023
@kgyrtkirk kgyrtkirk marked this pull request as ready for review September 20, 2023 16:21
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 20, 2023
View reviewed changes
...ration-tests/src/test/java/org/apache/druid/tests/ITAbstractQueryResourceTestClientTest.java
Comment on lines +119 to +121
private static final Injector INJECTOR = Initialization.makeInjectorWithModules(
GuiceInjectors.makeStartupInjector(),
getModules());

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Initialization.makeInjectorWithModules](1) should be avoided because it has been deprecated.
@kgyrtkirk
Copy link
Member Author

Bad approach

@kgyrtkirk kgyrtkirk closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kgyrtkirk