Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update RoaringBitmap to 0.9.49 #15006

Merged
merged 3 commits into from
Sep 20, 2023
Merged

update RoaringBitmap to 0.9.49 #15006

merged 3 commits into from
Sep 20, 2023

Conversation

xvrl
Copy link
Member

@xvrl xvrl commented Sep 18, 2023

  • update RoaringBitmap from 0.9.0 to 0.9.49

    Many optimizations and improvements have gone into recent releases of RoaringBitmap.
    It seems worthwhile to incorporate those.
    https://github.com/RoaringBitmap/RoaringBitmap/releases

  • update BatchIteratorAdapter to use PeekableIntIterator in order to implement
    newly added BatchIterator.advanceIfNeeded method

update RoaringBitmap from 0.9.0 to 0.9.49

Many optimizations and improvements have gone into recent releases of
RoaringBitmap. It seems worthwhile to incorporate those.
@xvrl xvrl force-pushed the update-roaring branch 2 times, most recently from 94c3b65 to 23c7f37 Compare September 18, 2023 18:54
@gianm
Copy link
Contributor

gianm commented Sep 19, 2023

Re-ran the failed IT. I don't think it's related but it'd be nice to see it pass.

@xvrl
Copy link
Member Author

xvrl commented Sep 19, 2023

@gianm the integration test in question seems to be failing in master as well https://github.com/apache/druid/actions/runs/6238900261/job/16937841853

@gianm
Copy link
Contributor

gianm commented Sep 20, 2023

Yeah I've seen that one be problematic in other PRs too. I don't think it's related to this PR so let's go ahead and merge it. Hopefully we can fix the bad IT soon.

@gianm gianm merged commit 22abc10 into apache:master Sep 20, 2023
73 of 74 checks passed
@xvrl xvrl deleted the update-roaring branch September 21, 2023 03:37
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants