Use annotation to mark DecoupleIgnore #15005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e922c82)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sql/src/test/java/org/apache/druid/sql/calcite/DecoupledPlanningCalciteQueryTest.java
Fixed
Show fixed
Hide fixed
imply-cheddar
approved these changes
Sep 19, 2023
sql/src/test/java/org/apache/druid/sql/calcite/DecoupledIgnore.java
Outdated
Show resolved
Hide resolved
rohangarg
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its a bit time consuming to check newly passing tests/etc; in #14996 the question came up "since when" some of those tests are passing....
This changeset introduces an annotation to mark disabled tests in decoupled mode - which has a few benefits:
the main difference is that they will still be executed ; but the expected error is classified.
In case it fails with the expected issue - it will put an ignore on the test result; however if the behaviour changes - it will fail the test.