Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log syntax for KubernetesTaskRunner #15004

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

georgew5656
Copy link
Contributor

@georgew5656 georgew5656 commented Sep 18, 2023

Since this function (deletePeonJobs) is deleting jobs and not tasks (doesn't make sense to delete tasks from k8s), we should log accordingly.

Description

Make debugging the KubernetesTaskRunner easier.

Release note

Cleanup some logs in the KubernetesTaskRunner for easier debugging.

Key changed/added classes in this PR
  • KubernetesPeonClient

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@suneet-s suneet-s merged commit d459df8 into apache:master Sep 18, 2023
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants