Enable SortProjectTransposeRule #15002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kgyrtkirk
commented
Sep 18, 2023
•
kgyrtkirk
commented
- contains Enable already passing tests in DecoupledPlanningCalciteQueryTest #14996
- enables a transpose rule to support a query plan in which the plan was in the shape:
| "s1", | ||
| new FieldAccessPostAggregator("s0", "a0:agg"), | ||
| "_p1", | ||
| new FieldAccessPostAggregator("_p0", "a0:agg"), |
There was a problem hiding this comment.
Why did these change?
There was a problem hiding this comment.
there are 2 callsites to create the postaggregates - one of them uses p and the other s as prefix; I was getting almost 100% matching plans with column alias mistmatches because of the different prefixes - so I've changed that; as the main importance of them is to have them unique.
I've today tried to remove the change of that prefix thing - and I think that change might not be needed in this patch.
I've update the PR
abhishekagarwal87
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.