-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to copy query results directly to clipboard #14889
Add option to copy query results directly to clipboard #14889
Conversation
fb96883
to
3cc1f4c
Compare
Hi @SamWheating! Thanks for the PR! The changes look good and this is a welcome feature. There are a few checkstyle failures in the build due to the imports. Could you please resolve them? |
678857d
to
b2d8937
Compare
@SamWheating - let us know once you fix the build so we can merge this PR. |
b2d8937
to
b5e4678
Compare
@abhishekagarwal87 thanks for the nudge, I thought I fixed it but it looks like I missed one other check. Should be fixed now but I'll keep an eye on the current CI run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. This is a really cool chance. Made some suggestions. LMK what you think.
web-console/src/views/workbench-view/execution-summary-panel/execution-summary-panel.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the feedback!
Description
This adds the option to copy query results directly to the clipboard.
Other database UIs (such as BigQuery) provide a similar option and I use it all the time to copy results into github comments, slack threads etc.
Demo:
(sorry for weird compression, I don't know how to make good screen-recording gifs)
Open Questions:
copyJSONResultsToClipboard
indownload.ts
, or should it live in its own file undersrc/utils/
Release note
Added option to copy query results in the UI directly to the clipboard
This PR has: