Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing query context params via JDBC URL #11664

Closed

Conversation

abhishekagarwal87
Copy link
Contributor

This PR adds support for passing context parameters via JDBC URL. The server will parse the query parameters out of the URL and store them in a thread-local state object that can be later used by DruidMeta to build the query context.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@asdf2014 asdf2014 added the Apache Avatica https://calcite.apache.org/avatica/ label Sep 7, 2021
@abhishekagarwal87 abhishekagarwal87 changed the title [WIP] Support passing context params via JDBC URL Support passing query context params via JDBC URL Sep 7, 2021
@clintropolis
Copy link
Member

clintropolis commented Sep 8, 2021

#10184 suggests that this should be handled by Avatica, did we investigate that avenue to support jdbc uri parameters? Or is that a different issue? (I haven't really looked at this PR yet).

I guess even if is the same issue, since the upstream issue has not been resolved yet considering how long this has been open it is reasonable to consider having some workaround here, but it does sort of seem conceptually like something that should be handled by Avatica so I wonder if it would be easier and more proper to fix there.

@stale
Copy link

stale bot commented Apr 28, 2022

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@stale stale bot added the stale label Apr 28, 2022
Copy link

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apache Avatica https://calcite.apache.org/avatica/ Area - SQL stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants