Skip to content

Commit

Permalink
Web console: fix Azure icon not rendering (#16173)
Browse files Browse the repository at this point in the history
* do not lowercase the icon name

* missing icon

* update test
  • Loading branch information
vogievetsky authored Mar 20, 2024
1 parent 488d376 commit e769ec7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ export function getIngestionTitle(ingestionType: IngestionComboTypeWithExtra): s

export function getIngestionImage(ingestionType: IngestionComboTypeWithExtra): string {
const parts = ingestionType.split(':');
if (parts.length === 2) return parts[1].toLowerCase();
if (parts.length === 2) return parts[1];
return ingestionType;
}

Expand Down Expand Up @@ -2071,6 +2071,7 @@ const TUNING_FORM_FIELDS: Field<IngestionSpec>[] = [
{
name: 'spec.tuningConfig.maxPendingPersists',
type: 'number',
defaultValue: 0,
hideInMore: true,
info: (
<>
Expand Down
1 change: 1 addition & 0 deletions web-console/src/utils/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ export function dataTypeToIcon(dataType: string): IconName {
return IconNames.SNOWFLAKE;

case 'COMPLEX<QUANTILESDOUBLESSKETCH>':
case 'COMPLEX<APPROXIMATEHISTOGRAM>':
return IconNames.HORIZONTAL_DISTRIBUTION;

case 'COMPLEX<VARIANCE>':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ exports[`LoadDataView matches snapshot batch 1`] = `
>
<img
alt="Ingestion tile for index_parallel:azureStorage"
src="/some/base_url/assets/azurestorage.png"
src="/some/base_url/assets/azureStorage.png"
/>
<p>
Azure Data Lake
Expand Down

0 comments on commit e769ec7

Please sign in to comment.