Skip to content

Commit

Permalink
Addressing comments
Browse files Browse the repository at this point in the history
  • Loading branch information
pranavbhole committed Oct 12, 2023
1 parent ca6b980 commit d389967
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,7 @@ static class ExpressionRowFunction implements RowFunction
public Object eval(final Row row)
{
try {
Object result = expr.eval(InputBindings.forRow(row)).valueOrDefault();
if (result != null && result.getClass().isArray()) {
return Rows.objectToStrings(result);
}
return result;
return expr.eval(InputBindings.forRow(row)).valueOrDefault();
}
catch (Throwable t) {
throw new ISE(t, "Could not transform value for %s reason: %s", name, t.getMessage());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,6 @@ public int compareTo(Row o)
}
});
Assert.assertEquals(actualTranformedRow.getDimension("dim"), dimList.subList(0, 5));
Assert.assertEquals(actualTranformedRow.getRaw("dim"), dimList.subList(0, 5));
Assert.assertArrayEquals(dimList.subList(0, 5).toArray(), (Object[]) actualTranformedRow.getRaw("dim"));
}
}

0 comments on commit d389967

Please sign in to comment.