Verify state again inside the runnable.

apache · Dec 20, 2024 · 5addd13 · 5addd13
1 parent 5403a0f
commit 5addd13
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...ice/src/main/java/org/apache/druid/indexing/scheduledbatch/ScheduledBatchTaskManager.java b/...ice/src/main/java/org/apache/druid/indexing/scheduledbatch/ScheduledBatchTaskManager.java
@@ -238,6 +238,10 @@ private synchronized void startScheduling()
       jobsExecutor.schedule(
           () -> {
             try {
+              // Check status inside the runnable again before submitting any tasks
+              if (status == ScheduledBatchSupervisorSnapshot.BatchSupervisorStatus.SCHEDULER_SHUTDOWN) {
+                return;
+              }
               lastTaskSubmittedTime = DateTimes.nowUtc();
               submitSqlTask(supervisorId, spec);
               emitMetric("batchSupervisor/tasks/submit/success", 1);
@@ -264,7 +268,7 @@ private void emitMetric(final String metricName, final int value)
           ServiceMetricEvent.builder()
                             .setDimension("supervisorId", supervisorId)
                             .setDimension("dataSource", dataSource)
-                            .setMetric(metricName, 1)
+                            .setMetric(metricName, value)
       );
     }
 

diff --git a/...src/test/java/org/apache/druid/indexing/scheduledbatch/ScheduledBatchTaskManagerTest.java b/...src/test/java/org/apache/druid/indexing/scheduledbatch/ScheduledBatchTaskManagerTest.java
@@ -220,7 +220,7 @@ public void testSupervisorStopsSubmittingJobsWhenSuspended()
     serviceEmitter.verifyEmitted(
         "batchSupervisor/tasks/submit/success",
         ImmutableMap.of("supervisorId", SUPERVISOR_ID_FOO),
-        2
+        1
     );
   }
-Original file line number
+Diff line change
@@ Expand Up @@
         serviceEmitter.verifyEmitted(
             "batchSupervisor/tasks/submit/success",
             ImmutableMap.of("supervisorId", SUPERVISOR_ID_FOO),
         );
       }
@@ Expand Down @@