put back assert; cleanup

apache · Oct 18, 2023 · 462eec6 · 462eec6
1 parent 0918a4f
commit 462eec6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java b/sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java
@@ -277,6 +277,7 @@ public static DruidQuery fromPartialQuery(
 
     if (partialQuery.getWindow() != null) {
       if (plannerContext.featureAvailable(EngineFeature.WINDOW_FUNCTIONS)) {
+        assert (virtualColumnRegistry.isEmpty());
         windowing = Preconditions.checkNotNull(
             Windowing.fromCalciteStuff(
                 partialQuery,

diff --git a/sql/src/main/java/org/apache/druid/sql/calcite/rel/Windowing.java b/sql/src/main/java/org/apache/druid/sql/calcite/rel/Windowing.java
@@ -142,8 +142,6 @@ public static Windowing fromCalciteStuff(
     }
 
     for (int i = 0; i < window.groups.size(); ++i) {
-
-      // FIXME: I think this should be recreated after every group
       VirtualColumnRegistry virtualColumnRegistry = VirtualColumnRegistry.create(
           sourceRowSignature,
           plannerContext.getExpressionParser(),