Migrate to Java 21 FFM API

The project's minimium java release requirements moved from Java 17 to Java 21. Package imports changed from `jdk.incubator.foreign` -> `java.lang.foreign` and a number of API changes were required. Notably, the new `java.lang.foreign.Arena` class needs to be exposed when allocating native memory regions as it controls the scope and lifecycle of allocations. Respective API docs are as follows: - https://docs.oracle.com/en/java/javase/17/docs/api/jdk.incubator.foreign/jdk/incubator/foreign/package-summary.html - https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/foreign/package-summary.html
apache · Nov 18, 2024 · 65edda9 · 65edda9
1 parent cf662bf
commit 65edda9
Show file tree

Hide file tree

Showing 45 changed files with 1,005 additions and 907 deletions.
diff --git a/nb-configuration.xml b/nb-configuration.xml
@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project-shared-configuration>
+    <!--
+This file contains additional configuration written by modules in the NetBeans IDE.
+The configuration is intended to be shared among all the users of project and
+therefore it is assumed to be part of version control checkout.
+Without this configuration present, some functionality in the IDE may be limited or fail altogether.
+-->
+    <properties xmlns="http://www.netbeans.org/ns/maven-properties-data/1">
+        <!--
+Properties that influence various parts of the IDE, especially code formatting and the like. 
+You can copy and paste the single properties, into the pom.xml file and the IDE will pick them up.
+That way multiple projects can share the same settings (useful for formatting rules for example).
+Any value defined here will override the pom.xml file value but is only applicable to the current project.
+-->
+        <netbeans.hint.jdkPlatform>JDK_21</netbeans.hint.jdkPlatform>
+        <netbeans.compile.on.save>all</netbeans.compile.on.save>
+    </properties>
+</project-shared-configuration>
diff --git a/pom.xml b/pom.xml
@@ -89,10 +89,10 @@ under the License.
 
     <!-- System-wide properties -->
     <maven.version>3.6.3</maven.version>
-    <java.version>17</java.version>
+    <java.version>21</java.version>
     <maven.compiler.source>${java.version}</maven.compiler.source>
     <maven.compiler.target>${java.version}</maven.compiler.target>
-    <argLine>-Xmx4g -Duser.language=en -Duser.country=US -Dfile.encoding=UTF-8 --add-modules=jdk.incubator.foreign</argLine>
+    <argLine>-Xmx4g -Duser.language=en -Duser.country=US -Dfile.encoding=UTF-8 --enable-preview</argLine>
     <charset.encoding>UTF-8</charset.encoding>
     <project.build.sourceEncoding>${charset.encoding}</project.build.sourceEncoding>
     <project.build.resourceEncoding>${charset.encoding}</project.build.resourceEncoding>
@@ -160,8 +160,9 @@ under the License.
           <artifactId>maven-compiler-plugin</artifactId>
           <version>${maven-compiler-plugin.version}</version>
           <configuration>
+            <release>21</release>
             <compilerArgs>
-              <arg>--add-modules=jdk.incubator.foreign</arg>
+              <arg>--enable-preview</arg>
             </compilerArgs>
           </configuration>
         </plugin>
@@ -187,7 +188,7 @@ under the License.
               <configuration>
                 <rules>
                   <requireJavaVersion>
-                    <version>[17,18)</version>
+                    <version>21</version>
                   </requireJavaVersion>
                   <requireMavenVersion>
                     <version>[${maven.version},4.0.0)</version>
@@ -235,7 +236,7 @@ under the License.
             <excludePackageNames>org.apache.datasketches.memory/internal</excludePackageNames>
             <show>public</show>
             <additionalOptions>
-              <additionalOption>--add-modules=jdk.incubator.foreign</additionalOption>
+              <additionalOption>--enable-preview</additionalOption>
             </additionalOptions>
           </configuration>
           <executions>
@@ -281,7 +282,7 @@ under the License.
           <artifactId>maven-surefire-plugin</artifactId>
           <version>${maven-surefire-failsafe-plugins.version}</version>
           <configuration>
-            <argLine>--add-modules=jdk.incubator.foreign</argLine>
+            <argLine>--enable-preview</argLine>
             <trimStackTrace>false</trimStackTrace>
             <useManifestOnlyJar>false</useManifestOnlyJar>
             <redirectTestOutputToFile>true</redirectTestOutputToFile>
@@ -307,6 +308,7 @@ under the License.
             <useDefaultExcludes>true</useDefaultExcludes>
             <excludes>
               <!-- rat uses .gitignore for excludes by default -->
+              <exclude>**/nb-configuration.xml</exclude>
               <exclude>**/*.yaml</exclude>
               <exclude>**/*.yml</exclude>
               <exclude>**/.*</exclude>

diff --git a/src/main/java/org/apache/datasketches/memory/Buffer.java b/src/main/java/org/apache/datasketches/memory/Buffer.java
@@ -19,6 +19,7 @@
 
 package org.apache.datasketches.memory;
 
+import java.lang.foreign.Arena;
 import java.nio.ByteBuffer;
 import java.nio.ByteOrder;
 

diff --git a/src/main/java/org/apache/datasketches/memory/DefaultMemoryRequestServer.java b/src/main/java/org/apache/datasketches/memory/DefaultMemoryRequestServer.java
@@ -19,10 +19,9 @@
 
 package org.apache.datasketches.memory;
 
+import java.lang.foreign.Arena;
 import java.nio.ByteOrder;
 
-import jdk.incubator.foreign.ResourceScope;
-
 /**
  * This example MemoryRequestServer is simple but demonstrates one of many ways to
  * manage continuous requests for larger memory.
@@ -59,7 +58,7 @@ public DefaultMemoryRequestServer(
   public WritableMemory request(
       final WritableMemory currentWmem,
       final long newCapacityBytes,
-      final ResourceScope scope) {
+      final Arena arena) {
     final ByteOrder order = currentWmem.getTypeByteOrder();
     final long currentBytes = currentWmem.getCapacity();
     final WritableMemory newWmem;
@@ -69,7 +68,7 @@ public WritableMemory request(
     }
 
     if (offHeap) {
-      newWmem = WritableMemory.allocateDirect(newCapacityBytes, 8, scope, order, this);
+      newWmem = WritableMemory.allocateDirect(arena, newCapacityBytes, 8, order, this);
     }
     else { //On-heap
       if (newCapacityBytes > Integer.MAX_VALUE) {
@@ -90,7 +89,7 @@ public void requestClose(
       final WritableMemory memToClose,
       final WritableMemory newMemory) {
     //make this operation idempotent.
-    if (memToClose.isCloseable()) { memToClose.scope().close(); }
+    if (memToClose.isCloseable()) { memToClose.close(); }
   }
 
 }
diff --git a/src/main/java/org/apache/datasketches/memory/Memory.java b/src/main/java/org/apache/datasketches/memory/Memory.java
@@ -22,13 +22,15 @@
 import java.io.ByteArrayOutputStream;
 import java.io.File;
 import java.io.IOException;
+import java.lang.foreign.Arena;
+import java.lang.foreign.MemorySegment;
+import java.lang.foreign.MemorySegment.Scope;
 import java.nio.ByteBuffer;
 import java.nio.ByteOrder;
+import java.util.Objects;
 
 import org.apache.datasketches.memory.internal.WritableMemoryImpl;
 
-import jdk.incubator.foreign.MemorySegment;
-import jdk.incubator.foreign.ResourceScope;
 
 /**
  * Defines the read-only API for offset access to a resource.
@@ -74,8 +76,9 @@ static Memory wrap(
   /**
    * Maps the given file into <i>Memory</i> for read operations
    * Calling this method is equivalent to calling
-   * {@link #map(File, long, long, ByteOrder)
+   * {@link #map(Arena, File, long, long, ByteOrder)
    * map(file, 0, file.length(), scope, ByteOrder.nativeOrder())}.
+   * @param arena the given arena. It must be non-null.
    * @param file the given file to map. It must be non-null with a non-negative length and readable.
    * @return <i>Memory</i> for managing the mapped memory.
    * @throws IllegalArgumentException if path is not associated with the default file system.
@@ -84,12 +87,13 @@ static Memory wrap(
    * @throws SecurityException If a security manager is installed and it denies an unspecified permission
    * required by the implementation.
    */
-  static Memory map(File file) throws IOException {
-    return map(file, 0, file.length(), ByteOrder.nativeOrder());
+  static Memory map(Arena arena, File file) throws IOException {
+    return map(arena, file, 0, file.length(), ByteOrder.nativeOrder());
   }
 
   /**
    * Maps the specified portion of the given file into <i>Memory</i> for read operations.
+   * @param arena the given arena. It must be non-null.
    * @param file the given file to map. It must be non-null,readable and length &ge; 0.
    * @param fileOffsetBytes the position in the given file in bytes. It must not be negative.
    * @param capacityBytes the size of the mapped memory. It must not be negative..
@@ -102,39 +106,12 @@ static Memory map(File file) throws IOException {
    * required by the implementation.
    */
   static Memory map(
+      Arena arena,
       File file,
       long fileOffsetBytes,
       long capacityBytes,
       ByteOrder byteOrder) throws IOException {
-    final ResourceScope scope = ResourceScope.newConfinedScope();
-    return WritableMemoryImpl.wrapMap(file, fileOffsetBytes, capacityBytes, scope, true, byteOrder);
-  }
-
-  /**
-   * Maps the specified portion of the given file into <i>Memory</i> for read operations with a ResourceScope.
-   * @param file the given file to map. It must be non-null, readable and length &ge; 0.
-   * @param fileOffsetBytes the position in the given file in bytes. It must not be negative.
-   * @param capacityBytes the size of the mapped memory. It must not be negative.
-   * @param scope the given ResourceScope.
-   * It must be non-null.
-   * Typically use <i>ResourceScope.newConfinedScope()</i>.
-   * Warning: specifying a <i>newSharedScope()</i> is not supported.
-   * @param byteOrder the byte order to be used.  It must be non-null.
-   * @return <i>Memory</i> for managing the mapped memory.
-   * @throws IllegalArgumentException  if path is not associated with the default file system.
-   * @throws IllegalStateException - if scope has been already closed, or if access occurs from a thread other
-   * than the thread owning scope.
-   * @throws IOException - if the specified path does not point to an existing file, or if some other I/O error occurs.
-   * @throws SecurityException - If a security manager is installed and it denies an unspecified permission
-   * required by the implementation.
-   */
-  static Memory map(
-      File file,
-      long fileOffsetBytes,
-      long capacityBytes,
-      ResourceScope scope,
-      ByteOrder byteOrder) throws IOException {
-    return WritableMemoryImpl.wrapMap(file, fileOffsetBytes, capacityBytes, scope, true, byteOrder);
+    return WritableMemoryImpl.wrapMap(arena, file, fileOffsetBytes, capacityBytes, true, byteOrder);
   }
 
   //NO ALLOCATE DIRECT, makes no sense

diff --git a/src/main/java/org/apache/datasketches/memory/MemoryRequestServer.java b/src/main/java/org/apache/datasketches/memory/MemoryRequestServer.java
@@ -19,13 +19,13 @@
 
 package org.apache.datasketches.memory;
 
-import jdk.incubator.foreign.ResourceScope;
+import java.lang.foreign.Arena;
 
 /**
  * The MemoryRequestServer is a callback interface to provide a means to request more memory
  * for heap and off-heap WritableMemory resources that are not file-memory-mapped backed resources.
  *
- * <p>Note: this only works with Java 17.
+ * <p>Note: this only works with Java 21.
  *
  * @author Lee Rhodes
  */
@@ -42,24 +42,24 @@ public interface MemoryRequestServer {
   default WritableMemory request(
       WritableMemory currentWritableMemory,
       long newCapacityBytes) {
-    return request(currentWritableMemory, newCapacityBytes, ResourceScope.newConfinedScope());
+
+    return request(currentWritableMemory, newCapacityBytes, Arena.ofConfined());
   }
 
   /**
    * Request new WritableMemory with the given newCapacityBytes. The current Writable Memory can be used to
    * determine the byte order of the returned WritableMemory and other properties.
    * @param currentWritableMemory the current writableMemory of the client. It must be non-null.
    * @param newCapacityBytes The capacity being requested. It must be &gt; the capacity of the currentWritableMemory.
-   * @param scope the ResourceScope to be used for the newly allocated memory.
-   * It must be non-null.
+   * @param arena the Arena to be used for the newly allocated memory. It must be non-null.
    * Typically use <i>ResourceScope.newConfinedScope()</i>.
    * Warning: specifying a <i>newSharedScope()</i> is not supported.
    * @return new WritableMemory with the requested capacity.
    */
   WritableMemory request(
       WritableMemory currentWritableMemory,
       long newCapacityBytes,
-      ResourceScope scope);
+      Arena arena);
 
   /**
    * Request to close the resource, if applicable.

diff --git a/src/main/java/org/apache/datasketches/memory/MurmurHash3.java b/src/main/java/org/apache/datasketches/memory/MurmurHash3.java
@@ -19,9 +19,9 @@
 
 package org.apache.datasketches.memory;
 
-import org.apache.datasketches.memory.internal.MurmurHash3v3;
+import java.lang.foreign.MemorySegment;
+import org.apache.datasketches.memory.internal.MurmurHash3v4;
 
-import jdk.incubator.foreign.MemorySegment;
 
 /**
  * <p>The MurmurHash3 is a fast, non-cryptographic, 128-bit hash function that has
@@ -39,13 +39,15 @@
  * <p>This implementation produces exactly the same hash result as the
  * MurmurHash3 function in datasketches-java given compatible inputs.</p>
  *
- * <p>This version 3 of the implementation leverages the jdk.incubator.foreign package of JDK-17 in place of
+ * <p>This version 4 of the implementation leverages the java.lang.foreign package of JDK-21 in place of
  * the Unsafe class.
  *
  * @author Lee Rhodes
  */
 public final class MurmurHash3 {
 
+  private MurmurHash3() { }
+
   //Provided for backward compatibility
 
   /**
@@ -59,7 +61,7 @@ public final class MurmurHash3 {
   public static long[] hash(
       final long[] in,
       final long seed) {
-    return MurmurHash3v3.hash(in, seed);
+    return MurmurHash3v4.hash(in, seed);
   }
 
   /**
@@ -73,7 +75,7 @@ public static long[] hash(
   public static long[] hash(
       final int[] in,
       final long seed) {
-    return MurmurHash3v3.hash(in, seed);
+    return MurmurHash3v4.hash(in, seed);
   }
 
   /**
@@ -87,7 +89,7 @@ public static long[] hash(
   public static long[] hash(
       final char[] in,
       final long seed) {
-    return MurmurHash3v3.hash(in, seed);
+    return MurmurHash3v4.hash(in, seed);
   }
 
   /**
@@ -101,7 +103,7 @@ public static long[] hash(
   public static long[] hash(
       final byte[] in,
       final long seed) {
-    return MurmurHash3v3.hash(in, seed);
+    return MurmurHash3v4.hash(in, seed);
   }
 
   //Single primitive inputs
@@ -118,7 +120,7 @@ public static long[] hash(
       final long in,
       final long seed,
       final long[] hashOut) {
-    return MurmurHash3v3.hash(in, seed, hashOut);
+    return MurmurHash3v4.hash(in, seed, hashOut);
   }
 
   /**
@@ -133,7 +135,7 @@ public static long[] hash(
       final double in,
       final long seed,
       final long[] hashOut) {
-    return MurmurHash3v3.hash(in, seed, hashOut);
+    return MurmurHash3v4.hash(in, seed, hashOut);
   }
 
   /**
@@ -148,7 +150,7 @@ public static long[] hash(
       final String in,
       final long seed,
       final long[] hashOut) {
-    return MurmurHash3v3.hash(in, seed, hashOut);
+    return MurmurHash3v4.hash(in, seed, hashOut);
   }
 
   //The main API calls
@@ -169,7 +171,7 @@ public static long[] hash(
       final long lengthBytes,
       final long seed,
       final long[] hashOut) {
-    return MurmurHash3v3.hash(mem, offsetBytes, lengthBytes, seed, hashOut);
+    return MurmurHash3v4.hash(mem, offsetBytes, lengthBytes, seed, hashOut);
   }
 
   /**
@@ -188,7 +190,7 @@ public static long[] hash(
       final long lengthBytes,
       final long seed,
       final long[] hashOut) {
-    return MurmurHash3v3.hash(seg, offsetBytes, lengthBytes, seed, hashOut);
+    return MurmurHash3v4.hash(seg, offsetBytes, lengthBytes, seed, hashOut);
   }
 
 }