Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation for all workflows #2 #620

Closed
wants to merge 29 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
5c7f5ab
Changes in ds-java required to move to java 17 as ds-java 7.x
leerho Jun 1, 2024
0bfac90
Fixes to align with modified Memory
leerho Jun 15, 2024
b984e65
Changes required for ds-java to move to java17 and also depend on
leerho Jun 20, 2024
59a3ff4
Add kll main 8 longs
leerho Oct 9, 2024
9c54687
Add all new kll longs files
leerho Oct 9, 2024
c0479b2
fix findbugs, includeMinMax, QuantilesUtil.
leerho Oct 9, 2024
7ee5cf3
More changes for 17
leerho Oct 9, 2024
2b44c6d
Added more robust checking of closing resources.
leerho Oct 10, 2024
9350991
remove extraneous offset increment
leerho Oct 10, 2024
e2f6b85
Updates to ds-java17
leerho Oct 13, 2024
9f48138
remove unnecessary cast
leerho Oct 13, 2024
3a5e67c
Update gitignore, pom, and fix one warning
leerho Nov 5, 2024
2355af7
Merge branch 'move_to_17_using_FFM' of [email protected]:apache/datasket…
leerho Nov 5, 2024
4a061fe
update GHA, pom
leerho Nov 17, 2024
d1853a9
Upload fixes as a result of CodeQL run.
leerho Nov 18, 2024
f42af45
Update again for coverage reported errors.
leerho Nov 18, 2024
34aaa8b
This huge update does not impact any code. It is mostly Javadoc updates.
leerho Dec 10, 2024
c57687b
Update README.md
leerho Dec 11, 2024
5fc852f
Update pom in preparation to create main based on 17.
leerho Dec 11, 2024
d0575f7
Update move_to_17_using_FFM with GHA workflow changes.
leerho Dec 17, 2024
8752c6a
update move_to_17_using_FFM with 6.1.X
leerho Dec 17, 2024
1417408
update GHA workflows
leerho Dec 18, 2024
341de43
update README.md
leerho Dec 18, 2024
babbe12
Release Process: update pom to 7.0.0
leerho Dec 18, 2024
5819b40
fix maven-javadoc-plugin version
leerho Dec 18, 2024
dc23277
Correct indentation in GHAW auto-check_cpp_files.yml
leerho Dec 19, 2024
301c560
Merge pull request #618 from apache/fix_gha_workflow_check_cpp_files
leerho Dec 19, 2024
d9539b0
Fix two minor errors in the GHA javadoc workflow
leerho Dec 19, 2024
12ec5c3
fix indentations in all workflows
leerho Dec 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: Serialization Compatibility Test

on:
pull_request:
push:
branches:
- master
branches: [ 7.0.X ]
workflow_dispatch:

jobs:
Expand All @@ -12,21 +12,34 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Checkout C++
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: apache/datasketches-cpp
path: cpp

- name: Setup Java
uses: actions/setup-java@v4
with:
java-version: '17'
distribution: 'temurin'

- name: Configure C++ build
run: cd cpp/build && cmake .. -DGENERATE=true

- name: Build C++ unit tests
run: cd cpp && cmake --build build --config Release

- name: Run C++ tests
run: cd cpp && cmake --build build --config Release --target test

- name: Make dir
run: mkdir -p serialization_test_data/cpp_generated_files

- name: Copy files
run: cp cpp/build/*/test/*_cpp.sk serialization_test_data/cpp_generated_files

- name: Run Java tests
run: mvn test -P check-cpp-files
103 changes: 55 additions & 48 deletions .github/workflows/auto-jdk-matrix.yml
Original file line number Diff line number Diff line change
@@ -1,65 +1,72 @@
name: DataSketches-Java Auto JDK Matrix Test & Install

on:
pull_request:
push:
branches: [ master ]
workflow_dispatch:
pull_request:
push:
branches: [ 7.0.X ]
workflow_dispatch:

env:
MAVEN_OPTS: -Xmx4g -Xms1g
MAVEN_OPTS: -Xmx4g -Xms1g

jobs:
build:
name: Build, Test, Install
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
jdk: [ 8,11 ]
env:
JDK_VERSION: ${{ matrix.jdk }}
build:
name: Build, Test, Install
runs-on: ubuntu-latest

steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v3
with:
persist-credentials: false
strategy:
fail-fast: false
matrix:
jdk: [ 17 ]

- name: Cache local Maven repository
uses: actions/cache@v3
with:
path: ~/.m2/repository
key: build-${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: build-${{ runner.os }}-maven-
env:
JDK_VERSION: ${{ matrix.jdk }}

- name: Install Matrix JDK
uses: actions/setup-java@v3
with:
java-version: ${{ matrix.jdk }}
distribution: 'temurin'
java-package: jdk
architecture: x64
# Architecture options: x86, x64, armv7, aarch64, ppc64le
# setup-java@v3 has a "with cache" option
steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Print Current workflow
run: >
cat .github/workflows/auto-jdk-matrix.yml

- name: Cache local Maven repository
uses: actions/cache@v4
with:
path: ~/.m2/repository
key: build-${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: build-${{ runner.os }}-maven-

- name: Echo Java Version
run: >
java -version
- name: Install Matrix JDK
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.jdk }}
distribution: 'temurin'
java-package: jdk
architecture: x64

- name: Test
run: >
mvn clean test
-Dmaven.javadoc.skip=true
-Dgpg.skip=true
- name: Echo Java Version
run: >
java -version

- name: Install
run: >
mvn clean install -B
-DskipTests=true
-Dgpg.skip=true
- name: Test
run: >
mvn clean test -B
-Dmaven.javadoc.skip=true
-Dgpg.skip=true

- name: Install
run: >
mvn clean install -B
-DskipTests=true
-Dgpg.skip=true

# Architecture options: x86, x64, armv7, aarch64, ppc64le
# setup-java@v4 has a "with cache" option
# Lifecycle: validate, compile, test, package, verify, install, deploy
# -B batch mode
# -B batch mode, never stops for user input
# -V show Version without stopping
# -X debug mode
# -q quiet, only show errors
81 changes: 81 additions & 0 deletions .github/workflows/auto-os-matrix.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
name: DataSketches-Java Auto OS Matrix Test & Install

on:
pull_request:
push:
branches: [ 7.0.X ]
workflow_dispatch:

env:
MAVEN_OPTS: -Xmx1g -Xms1g

jobs:
build:
name: Build, Test, Install

strategy:
fail-fast: false

matrix:
jdk: [ 17 ]
os: [ windows-latest, ubuntu-latest, macos-latest ]
include:
- os: windows-latest
skip_javadoc: "`-Dmaven`.javadoc`.skip=true"
skip_gpg: "`-Dgpg`.skip=true"
- os: ubuntu-latest
skip_javadoc: -Dmaven.javadoc.skip=true
skip_gpg: -Dgpg.skip=true
- os: macos-latest
skip_javadoc: -Dmaven.javadoc.skip=true
skip_gpg: -Dgpg.skip=true

runs-on: ${{matrix.os}}

env:
JDK_VERSION: ${{ matrix.jdk }}

steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Cache local Maven repository
uses: actions/cache@v4
with:
path: ~/.m2/repository
key: build-${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: build-${{ runner.os }}-maven-

- name: Install Matrix JDK
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.jdk }}
distribution: 'temurin'
java-package: jdk
architecture: x64

- name: Echo Java Version
run: >
java -version

- name: Test
run: >
mvn clean test
${{matrix.os.skip_javadoc}}
${{matrix.os.skip_gpg}}

- name: Install
run: >
mvn clean install -B
${{matrix.os.skip_javadoc}}
-D skipTests=true
${{matrix.os.skip_gpg}}

# Architecture options: x86, x64, armv7, aarch64, ppc64le
# setup-java@v4 has a "with cache" option
# Lifecycle: validate, compile, test, package, verify, install, deploy
# -B batch mode
# -V show Version without stopping
# -q quiet, only show errors
64 changes: 0 additions & 64 deletions .github/workflows/codeql-analysis.yml

This file was deleted.

23 changes: 0 additions & 23 deletions .github/workflows/javadoc.yml

This file was deleted.

57 changes: 57 additions & 0 deletions .github/workflows/manual-codeql-analysis.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
name: "CodeQL"

on:
workflow_dispatch:

jobs:
analyze:
name: Analyze
runs-on: ubuntu-latest
permissions:
actions: read
contents: read
security-events: write

strategy:
fail-fast: false
matrix:
language: [ 'java' ]
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
# Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support

steps:
- name: Checkout repository
uses: actions/checkout@v4

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v4
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
# By default, queries listed here will override any specified in a config file.
# Prefix the list here with "+" to use these queries and those in the config file.

# Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
queries: +security-and-quality


# Autobuild attempts to build any compiled languages (C/C++, C#, Go, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v4

# Command-line programs to run using the OS shell.
# See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun

# If the Autobuild fails above, remove it and uncomment the following three lines.
# modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.

# - run: |
# echo "Run, Build Application using script"
# ./location_of_script_within_repo/buildscript.sh

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v4
with:
category: "/language:${{matrix.language}}"
Loading
Loading