Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull master into 6.1.X #617

Closed
wants to merge 32 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
336b28b
Merge pull request #592 from apache/Release_process_update_pom
leerho Aug 23, 2024
81edc3f
Update POM to next anticipated version: 6.2.0-SNAPSHOT
leerho Aug 23, 2024
3d4e194
Merge pull request #594 from apache/Update_pom_to_6.2.0-SNAPSHOT
leerho Aug 23, 2024
5e277f4
Add one exclusion to FindBugsExcludeFilter.xml.
leerho Sep 5, 2024
dcfa646
Update Memory dependency to 3.0.1.
leerho Sep 5, 2024
09ffacc
Merge pull request #598 from apache/cherry-pick_6.1.0_to_master
leerho Sep 6, 2024
d143482
Add .vscode to .gitignore
leerho Sep 12, 2024
27e85a3
Fix .gitignore
leerho Sep 15, 2024
598f2d1
Fix website references.
leerho Sep 23, 2024
fadfd64
Merge pull request #600 from apache/add_.vscode_to_.gitignore
leerho Sep 25, 2024
d9ace43
Merge branch 'master' into fix_website_refs
leerho Sep 25, 2024
511ed6c
These tests were attempting to
leerho Sep 27, 2024
063e012
Merge pull request #601 from apache/fix_website_refs
leerho Sep 27, 2024
2912622
Merge pull request #602 from apache/fix_direct_overfill_tests
leerho Sep 27, 2024
dedd85e
Update memory dependency to 3.0.2.
leerho Oct 5, 2024
304e174
Fix website references.
leerho Sep 23, 2024
505e686
Merge pull request #603 from apache/update_memory_dep_to_3.0.2
leerho Oct 5, 2024
dd96fca
Remove extra slashed in Master.
leerho Oct 7, 2024
34304ef
Merge pull request #608 from apache/remove_extra_slashes
leerho Oct 9, 2024
e9154ff
Update Master from 6.1.1
leerho Oct 11, 2024
67b654b
explicit java setup
AlexanderSaydakov Oct 15, 2024
b259334
use checkout v4
AlexanderSaydakov Oct 15, 2024
9fa6ec3
Merge pull request #610 from apache/setup-java-action
AlexanderSaydakov Oct 15, 2024
2e9b84e
Merge pull request #609 from apache/update_master_from_6.1.1
jmalkin Oct 16, 2024
e674162
implemented getPMF() and getCDF()
AlexanderSaydakov Nov 1, 2024
9d1d45b
corrected the exception thrown
AlexanderSaydakov Nov 1, 2024
c07bca2
added import
AlexanderSaydakov Nov 1, 2024
33d8ad5
Merge pull request #612 from apache/tdigest_pmf_cdf
AlexanderSaydakov Nov 1, 2024
26a562c
align master with 6.1.X Also
leerho Dec 12, 2024
4f92140
updating workflows to match how they are configured
leerho Dec 13, 2024
259aa39
Merge pull request #614 from apache/align_master_with_6.1.X
leerho Dec 13, 2024
810e869
Add LF at end of file.
leerho Dec 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ name: Serialization Compatibility Test

on:
push:
branches:
- master
branches: [ master, main ]
workflow_dispatch:

jobs:
Expand All @@ -12,12 +11,17 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Checkout C++
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
repository: apache/datasketches-cpp
path: cpp
- name: Setup Java
uses: actions/setup-java@v4
with:
java-version: '11'
distribution: 'temurin'
- name: Configure C++ build
run: cd cpp/build && cmake .. -DGENERATE=true
- name: Build C++ unit tests
Expand Down
21 changes: 14 additions & 7 deletions .github/workflows/auto-jdk-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: DataSketches-Java Auto JDK Matrix Test & Install
on:
pull_request:
push:
branches: [ master ]
branches: [ master, main ]
workflow_dispatch:

env:
Expand All @@ -13,43 +13,47 @@ jobs:
build:
name: Build, Test, Install
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
jdk: [ 8,11 ]

env:
JDK_VERSION: ${{ matrix.jdk }}

steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Print Current workflow
run: >
cat .github/workflows/auto-jdk-matrix.yml

- name: Cache local Maven repository
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.m2/repository
key: build-${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: build-${{ runner.os }}-maven-

- name: Install Matrix JDK
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.jdk }}
distribution: 'temurin'
java-package: jdk
architecture: x64
# Architecture options: x86, x64, armv7, aarch64, ppc64le
# setup-java@v3 has a "with cache" option

- name: Echo Java Version
run: >
java -version

- name: Test
run: >
mvn clean test
mvn clean test -B
-Dmaven.javadoc.skip=true
-Dgpg.skip=true

Expand All @@ -59,7 +63,10 @@ jobs:
-DskipTests=true
-Dgpg.skip=true

# Architecture options: x86, x64, armv7, aarch64, ppc64le
# setup-java@v3 has a "with cache" option
# Lifecycle: validate, compile, test, package, verify, install, deploy
# -B batch mode
# -V show Version without stopping
# -X debug mode
# -q quiet, only show errors
Original file line number Diff line number Diff line change
@@ -1,19 +1,23 @@
name: DataSketches-Java Manual OS Matrix Test & Install
name: DataSketches-Java 8 Auto OS Matrix Test & Install

on:
pull_request:
push:
branches: [ master, main ]
workflow_dispatch:

env:
MAVEN_OPTS: -Xmx4g -Xms1g
MAVEN_OPTS: -Xmx1g -Xms1g

jobs:
build:
name: Build, Test, Install
runs-on: ${{matrix.os}}

strategy:
fail-fast: false

matrix:
jdk: [ 8, 11 ]
jdk: [ 8 ]
os: [ windows-latest, ubuntu-latest, macos-latest ]
include:
- os: windows-latest
Expand All @@ -26,31 +30,31 @@ jobs:
skip_javadoc: -Dmaven.javadoc.skip=true
skip_gpg: -Dgpg.skip=true

runs-on: ${{matrix.os}}

env:
JDK_VERSION: ${{ matrix.jdk }}

steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
persist-credentials: false

- name: Cache local Maven repository
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.m2/repository
key: build-${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: build-${{ runner.os }}-maven-

- name: Install Matrix JDK
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.jdk }}
distribution: 'temurin'
java-package: jdk
architecture: x64
# Architecture options: x86, x64, armv7, aarch64, ppc64le
# setup-java@v3 has a "with cache" option

- name: Echo Java Version
run: >
Expand All @@ -69,6 +73,8 @@ jobs:
-D skipTests=true
${{matrix.os.skip_gpg}}

# Architecture options: x86, x64, armv7, aarch64, ppc64le
# setup-java@v4 has a "with cache" option
# Lifecycle: validate, compile, test, package, verify, install, deploy
# -B batch mode
# -V show Version without stopping
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
name: "CodeQL"

on:
push:
branches: [ 'master' ]
pull_request:
# The branches below must be a subset of the branches above
branches: [ 'master' ]
schedule:
- cron: '10 17 * * 4'
workflow_dispatch:

jobs:
Expand All @@ -28,11 +21,11 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v3
uses: github/codeql-action/init@v4
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
Expand Down
71 changes: 0 additions & 71 deletions .github/workflows/manual-coverage.yml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@
name: JavaDoc

on:
push:
branches:
- master
workflow_dispatch:

jobs:
javadoc:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Generate JavaDoc
run: mvn javadoc:javadoc
- name: Deploy JavaDoc
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
*.ipr
*.iws

# VSCode project files
**/.vscode/

# Additional tools
.clover/

Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ under the License.

<groupId>org.apache.datasketches</groupId>
<artifactId>datasketches-java</artifactId>
<version>6.1.0-SNAPSHOT</version>
<version>6.2.0-SNAPSHOT</version>
<packaging>jar</packaging>

<name>${project.artifactId}</name>
Expand Down Expand Up @@ -83,7 +83,7 @@ under the License.
</developers>

<properties>
<datasketches-memory.version>3.0.0</datasketches-memory.version>
<datasketches-memory.version>3.0.2</datasketches-memory.version>

<!-- Test -->
<testng.version>7.5.1</testng.version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
import org.apache.datasketches.memory.XxHash;

/**
* <p>A Bloom filter is a data structure that can be used for probabilistic
* set membership.</p>
* A Bloom filter is a data structure that can be used for probabilistic
* set membership.
*
* <p>When querying a Bloom filter, there are no false positives. Specifically:
* When querying an item that has already been inserted to the filter, the filter will
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
import org.apache.datasketches.memory.WritableMemory;

/**
* <p>This class provides methods to help estimate the correct parameters when
* creating a Bloom filter, and methods to create the filter using those values.</p>
* This class provides methods to help estimate the correct parameters when
* creating a Bloom filter, and methods to create the filter using those values.
*
* <p>The underlying math is described in the
* <a href='https://en.wikipedia.org/wiki/Bloom_filter#Optimal_number_of_hash_functions'>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@
import org.apache.datasketches.memory.WritableMemory;

/**
* <p>This sketch is useful for tracking approximate frequencies of items of type <i>&lt;T&gt;</i>
* This sketch is useful for tracking approximate frequencies of items of type <i>&lt;T&gt;</i>
* with optional associated counts (<i>&lt;T&gt;</i> item, <i>long</i> count) that are members of a
* multiset of such items. The true frequency of an item is defined to be the sum of associated
* counts.</p>
* counts.
*
* <p>This implementation provides the following capabilities:</p>
* <ul>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@
import org.apache.datasketches.memory.WritableMemory;

/**
* <p>This sketch is useful for tracking approximate frequencies of <i>long</i> items with optional
* This sketch is useful for tracking approximate frequencies of <i>long</i> items with optional
* associated counts (<i>long</i> item, <i>long</i> count) that are members of a multiset of
* such items. The true frequency of an item is defined to be the sum of associated counts.</p>
* such items. The true frequency of an item is defined to be the sum of associated counts.
*
* <p>This implementation provides the following capabilities:</p>
* <ul>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,11 @@
/**
* This class defines the preamble data structure and provides basic utilities for some of the key
* fields.
* <p>
* The intent of the design of this class was to isolate the detailed knowledge of the bit and byte
*
* <p>The intent of the design of this class was to isolate the detailed knowledge of the bit and byte
* layout of the serialized form of the sketches derived from the Sketch class into one place. This
* allows the possibility of the introduction of different serialization schemes with minimal impact
* on the rest of the library.
* </p>
* on the rest of the library.</p>
*
* <p>
* MAP: Low significance bytes of this <i>long</i> data structure are on the right. However, the
Expand Down
2 changes: 0 additions & 2 deletions src/main/java/org/apache/datasketches/hash/MurmurHash3.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,8 @@
import org.apache.datasketches.memory.Memory;

/**
* <p>
* The MurmurHash3 is a fast, non-cryptographic, 128-bit hash function that has
* excellent avalanche and 2-way bit independence properties.
* </p>
*
* <p>
* Austin Appleby's C++
Expand Down
Loading
Loading