Fix a memory leak in test. #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmalkin
reviewed
Aug 17, 2024
| wmem.close(); | ||
| //note wmem2 has already been closed by the DefaultMemoryRequestServer | ||
| wmem.close(); //empty, but we must close it anyway. | ||
| //note wmem2 has already been closed by the DefaultMemoryRequestServer. |
There was a problem hiding this comment.
could do assertFalse(wmem2.isAlive()) here rather than just a comment?
jmalkin
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a memory leak in the tests. It only shows up when the tests run long enough and generate enough garbage for the garbage collector to activate and call finalize. It only showed up when running all the tests for the java library. Running individual tests it will not show up. I would see the warning after all the tests have run, but, of course, the warning message doesn't provide any clues about where the culprit is, it can't! It was kind of a cat-and-mouse game to find it, but I finally figured out a way to track it down.
This leak has been there a while, but it was only in the test code. So no real harm done. Release 6.1.0 is coming soon, I think it is safe to release it then.