Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotient filter reviewed #579

Draft
wants to merge 54 commits into
base: master
Choose a base branch
from
Draft

Quotient filter reviewed #579

Show file tree
Hide file tree
Changes from 39 commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
7a8e838
Added initial QF builder functions
c-dickens May 2, 2024
2080ec3
Factored in QF code and added QF unit tests
c-dickens May 7, 2024
532a77a
Tidied java doc github build issue
c-dickens May 8, 2024
9397e9c
Initial javadoc correction
c-dickens May 8, 2024
25288bd
Corrected some javadocs?
c-dickens May 8, 2024
4ab30de
javadocs edits
c-dickens May 8, 2024
fc40321
javadoc edits
c-dickens May 8, 2024
90701eb
Added licenses
c-dickens May 8, 2024
a9f9027
Added bitvector tests
c-dickens May 15, 2024
03f9c52
Corrected license header
c-dickens May 15, 2024
e5e0f0f
Merge pull request #558 from apache/quotient-filter
c-dickens May 23, 2024
940eda8
circular table, no extension slots
AlexanderSaydakov May 23, 2024
cf3eb3c
removed unnecessary scan to compute the number of entries
AlexanderSaydakov May 23, 2024
68be9a8
fixed deletions
AlexanderSaydakov May 24, 2024
da8656f
Updated the overflow test to check the wrapping.
c-dickens May 28, 2024
c7b970a
Merge pull request #562 from apache/quotient-filter
c-dickens May 28, 2024
9ee3ddf
Merge branch 'quotient-filter' of github.com:apache/datasketches-java…
jmalkin May 28, 2024
87abf9c
no need to find the first empty slot
AlexanderSaydakov May 28, 2024
62776da
use the same method to shift
AlexanderSaydakov May 29, 2024
01c7491
Merge pull request #564 from apache/quotient-filter
AlexanderSaydakov May 30, 2024
97575b0
fixed find_run_start() and removed adjustment in insert_new_run()
AlexanderSaydakov May 31, 2024
8a8bfbc
removed whitespace
AlexanderSaydakov May 31, 2024
31fd85d
removed unnecessary method
AlexanderSaydakov May 31, 2024
158b91b
move BloomFilter's underlying BitArray into common directory, update …
jmalkin May 31, 2024
c7f010a
Merge pull request #566 from apache/quotient-filter
AlexanderSaydakov May 31, 2024
f7c7bd0
Cleanup based on review feedback
jmalkin May 31, 2024
16dbc16
slightly simplify mask logic in bitarray
jmalkin May 31, 2024
9b74797
Merge pull request #567 from apache/common_bitarray
jmalkin May 31, 2024
2fd8313
no insertions of duplicates
AlexanderSaydakov Jun 3, 2024
d5e0d2d
Merge pull request #570 from apache/quotient-filter
AlexanderSaydakov Jun 4, 2024
5aa9191
ordered runs, simplified insertion code
AlexanderSaydakov Jun 4, 2024
f49c7a0
removed comment that is no longer valid
AlexanderSaydakov Jun 4, 2024
3d60bce
commented shifting the rest of the cluster after the insertion point
AlexanderSaydakov Jun 5, 2024
1ea45c0
better wording
AlexanderSaydakov Jun 5, 2024
2a558a4
Merge pull request #571 from apache/quotient-filter
AlexanderSaydakov Jun 5, 2024
078c1f4
style changes
AlexanderSaydakov Jun 13, 2024
5359b6a
Merge pull request #573 from apache/quotient-filter
AlexanderSaydakov Jun 18, 2024
9f9f549
expansion and some more cleanup
AlexanderSaydakov Jun 18, 2024
ccdabc4
Merge pull request #575 from apache/quotient-filter
leerho Jun 22, 2024
2064c3c
constructor takes fingerprint length and load factor
AlexanderSaydakov Jul 9, 2024
28042bd
Merge pull request #581 from apache/quotient-filter
AlexanderSaydakov Jul 11, 2024
ffc9bbc
implemented merge
AlexanderSaydakov Jul 15, 2024
ff12ef7
Added load factor change into builder functionality
c-dickens Jul 16, 2024
fb44a36
Updated builder function to account for new load factor
c-dickens Jul 16, 2024
e1f3d97
Revert "Added load factor change into builder functionality"
c-dickens Jul 16, 2024
f9514fa
changed 0.9f -> 0.9
c-dickens Jul 16, 2024
b742749
changed load facto 0.8f -> 0.8
c-dickens Jul 16, 2024
22ba835
removed debug print
AlexanderSaydakov Jul 16, 2024
9d3a4cd
fixed merge test
AlexanderSaydakov Jul 16, 2024
36a675d
Merge pull request #582 from apache/quotient-filter
AlexanderSaydakov Jul 17, 2024
e851f89
Reverted double laod factor to float and corrected builder tests
c-dickens Jul 25, 2024
b9bfab3
Merge pull request #584 from apache/quotient-filter
c-dickens Jul 26, 2024
9a93a94
cleanup
AlexanderSaydakov Aug 2, 2024
600598e
Merge pull request #586 from apache/quotient-filter
AlexanderSaydakov Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 0 additions & 135 deletions src/main/java/org/apache/datasketches/filters/bloomfilter/BitArray.java
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions src/main/java/org/apache/datasketches/filters/bloomfilter/BloomFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
import org.apache.datasketches.common.Family;
import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.common.SketchesStateException;
import org.apache.datasketches.filters.common.BitArray;
import org.apache.datasketches.filters.common.DirectBitArray;
import org.apache.datasketches.filters.common.HeapBitArray;
import org.apache.datasketches.memory.Buffer;
import org.apache.datasketches.memory.Memory;
import org.apache.datasketches.memory.WritableBuffer;
Expand Down
Loading
Loading