Remove duplicate code #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whole bunch of duplicate code in KLL. Plus some other code cleanup and javadoc cleanup. Changes to some test code to help with diagnostic understanding of the operation of the sketch.
Fixed some SpotBugs issues.
| @@ -806,31 +707,32 @@ private static long intCapAux(final int k, final int depth) { | |||
| /** | |||
| * Performs the integer based calculation of an individual level (or folded level). | |||
| * @param k the configured k of the sketch | |||
| * @param depth depth the zero-based index of the level being computed. | |||
| * @param depth the zero-based index of the level being computed. The max depth is 30! | |||
There was a problem hiding this comment.
do we need "!" in docs?
AlexanderSaydakov
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to do the next set of updates in smaller batches.