HLL Union toString is not pure and can trigger a rebuild #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leerho
approved these changes
Dec 7, 2023
|
Thank you! Excellent fix! |
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Jan 3, 2024
### What changes were proposed in this pull request? This pr aims to upgarde `datasketches-java` from 3.3.0 to 5.0.1. Additionally, this PR adds handling for `SketchesArgumentException` to ensure backward compatibility for exceptional test scenarios in `hll.sql`. ### Why are the changes needed? The new brings some bug fix and improvements, like - apache/datasketches-java#437 - apache/datasketches-java#482 The full release notes as follows: - https://github.com/apache/datasketches-java/releases/tag/4.0.0 - https://github.com/apache/datasketches-java/releases/tag/4.1.0 - https://github.com/apache/datasketches-java/releases/tag/4.2.0 - https://github.com/apache/datasketches-java/releases/tag/5.0.0 - https://github.com/apache/datasketches-java/releases/tag/5.0.1 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #44547 from LuciferYang/datasketches-java-5. Lead-authored-by: yangjie01 <[email protected]> Co-authored-by: YangJie <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The toString method of Union can mutate the object if a rebuild is necessary.
This make some test fail when running in debug (as some IDE will render object value automatically).
Not a major issue, but surely unexpected to have toString() mutate the object.
Thanks !