Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add related source code locations to errors #13664

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Add related source code locations to errors #13664

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e4bbffa
Temp patch to new sqlparser
alamb Nov 24, 2024
3545647
Update for new sqlparser API
alamb Nov 24, 2024
34c388a
feat: init diagnostics
eliaperantoni Dec 5, 2024
dee7959
feat: diagnostics for unknown columns and missing in `GROUP BY`
eliaperantoni Dec 6, 2024
515bb5e
feat: `FieldSpans` and ambiguous column reference diagnostics
eliaperantoni Dec 9, 2024
cdee494
Merge branch 'main' into eper/diagnostics
eliaperantoni Dec 9, 2024
03afbf6
feat: UNION wrong number of fields diagnostics
eliaperantoni Dec 10, 2024
2d3e2a1
feat: collect more errors
eliaperantoni Dec 10, 2024
0506a80
feat: ignorable errors
eliaperantoni Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ sqlparser = { version = "0.52.0", features = ["visitor"] }
tempfile = "3"
tokio = { version = "1.36", features = ["macros", "rt", "sync"] }
url = "2.2"
derivative = "2.2.0"

[profile.release]
codegen-units = 1
Expand All @@ -175,3 +176,7 @@ large_futures = "warn"
[workspace.lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ["cfg(tarpaulin)"] }
unused_qualifications = "deny"

## Temp patch for sqlparser
[patch.crates-io]
sqlparser = { git = "https://github.com/apache/datafusion-sqlparser-rs.git", rev = "4ab3ab91473d152c652e6582b63abb13535703f9" }
Loading
Loading