chore(deps): update bigdecimal from 0.4.1 to 0.4.6 #13569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, I was experimenting with env var, I didn't work well |
I tested it on this branch, and it works except for one query. |
|
Good catch |
findepi
reviewed
Dec 2, 2024
| // Round the value to limit the number of decimal places | ||
| let value = value.round(12).normalized(); | ||
| // Format the value to a string | ||
| format_big_decimal(value) |
There was a problem hiding this comment.
we could use bigdecimal to_plain_string (see akubera/bigdecimal-rs#135) -- but it's not released yet afaict
fwiw, i faced same issuues when upgrading the bigdecimal dep in an internal project based on DataFusion and felt the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10001.
Rationale for this change
We use the bigdecimal crate to format decimal values to strings and display them in sqllogical tests(SLTs).
The new version of bigdecimal formats certain decimals in scientific notation, which will break many SLT tests.
There are two possible solutions:
RUST_BIGDECIMAL_FMT_EXPONENTIAL_LOWER_THRESHOLD. However, I'm a bit concerned about whether it's appropriate to operate environment variables in a library like DataFusion. Additionally, we might need to introduce a separate Cargo config.toml into the project root directory so thatcargo test --test sqllogictestscan work.This PR takes the latter approach.
What changes are included in this PR?
Are these changes tested?
Yes. By new UTs and existing SLT tests.
Are there any user-facing changes?
No. Only modified the test engine.