Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ballista proto cleanup #1146

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

milenkovicm
Copy link
Contributor

Which issue does this PR close?

Closes none.

Rationale for this change

Cleanup and simplification of ballista.proto and code around it

What changes are included in this PR?

There are few changes:

  • value ofKeyValuePair should be optional as it was used with optional configurations values
  • few oneOfs have been replaced with optional
  • Unused message has been removed

Are there any user-facing changes?

No

@milenkovicm milenkovicm force-pushed the feat_make_pair_optional branch from f1d4625 to 27a4300 Compare December 3, 2024 20:09
@andygrove andygrove merged commit cc2ddcb into apache:main Dec 5, 2024
24 checks passed
@milenkovicm milenkovicm deleted the feat_make_pair_optional branch December 5, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants