fix some todo comments

apache · Dec 11, 2023 · 6d17c70 · 6d17c70
1 parent c9f821d
commit 6d17c70
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 9 deletions.
diff --git a/ballista/core/src/cache_layer/object_store/file.rs b/ballista/core/src/cache_layer/object_store/file.rs
@@ -88,11 +88,15 @@ where
 
     async fn put_opts(
         &self,
-        location: &Path,
-        bytes: Bytes,
-        opts: PutOptions,
+        _location: &Path,
+        _bytes: Bytes,
+        _opts: PutOptions,
     ) -> object_store::Result<PutResult> {
-        todo!()
+        Err(Error::NotSupported {
+            source: Box::new(BallistaError::General(
+                "Write path is not supported".to_string(),
+            )),
+        })
     }
 
     async fn put_multipart(
@@ -225,8 +229,9 @@ where
 
     fn list(
         &self,
-        prefix: Option<&Path>,
+        _prefix: Option<&Path>,
     ) -> BoxStream<'_, object_store::Result<ObjectMeta>> {
+        // TODO we can no longer return an Err here
         // Err(Error::NotSupported {
         //     source: Box::new(BallistaError::General("List is not supported".to_string())),
         // })

diff --git a/ballista/core/src/cache_layer/object_store/mod.rs b/ballista/core/src/cache_layer/object_store/mod.rs
@@ -71,11 +71,11 @@ impl ObjectStore for ObjectStoreWithKey {
 
     async fn put_opts(
         &self,
-        _location: &Path,
-        _bytes: Bytes,
-        _opts: PutOptions,
+        location: &Path,
+        bytes: Bytes,
+        opts: PutOptions,
     ) -> object_store::Result<PutResult> {
-        todo!()
+        self.inner.put_opts(location, bytes, opts).await
     }
 
     async fn put_multipart(