Add s390x support to CouchDB docker image #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kun-Lu <[email protected]>
|
Hi @nickva , Could you please take a look at this PR as well? Thank you so much! |
|
Thank you for your contribution, @kun-lu20! |
|
Thanks @nickva ! |
|
Hi @nickva , Could you please update the following file as well, so that the docker official image of CouchDB v3.3.2+ can have s390x support? Thank you so much! |
|
@kun-lu20, sure thing, thanks for the reminder. I created a PR: docker-library/official-images#14752 |
|
Thanks @nickva ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Since the s390x .deb binary on debian:bullseye is released from v3.3.2 afterwards and all pre-requisites mentioned in #67 (comment) are available now, this PR aims to add s390x support to CouchDB docker image.
Testing recommendations
https://github.com/apache/couchdb-docker#how-to-use-this-image
https://docs.couchdb.org/en/stable/intro/tour.html
I've built the multi-arch docker image on an Intel VM after applying the code change in this PR and verified the generated s390x image on a s390x VM. It worked fine.
GitHub issue number
#67
Checklist