Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Hide section divider when all OAuth providers are disabled #9966

Open
wants to merge 1 commit into
base: 4.19
Choose a base branch
from

Conversation

bernardodemarco
Copy link
Collaborator

Description

Currently, when all OAuth providers are disabled, the authentication page still displays the section divider below the login form.

This PR addresses this issue by ensuring the section divider is only rendered when at least one OAuth provider is enabled.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before

image

After

image

How Has This Been Tested?

  • Verified that when at least one OAuth provider is enabled, both the section divider and the OAuth provider sign-in options are rendered correctly.
  • Verified that when all OAuth providers are disabled, the section divider is no longer displayed.

@bernardodemarco
Copy link
Collaborator Author

@blueorangutan ui

@blueorangutan
Copy link

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.10%. Comparing base (a2690e9) to head (6c75e5e).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9966      +/-   ##
============================================
- Coverage     15.10%   15.10%   -0.01%     
+ Complexity    11225    11220       -5     
============================================
  Files          5404     5404              
  Lines        473502   473502              
  Branches      57733    57734       +1     
============================================
- Hits          71543    71527      -16     
- Misses       393961   393981      +20     
+ Partials       7998     7994       -4     
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9966 (QA-JID-484)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland added this to the 4.19.2 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants