Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemvm: fix keystore is reset when patch a systemvm #9900

Open
wants to merge 1 commit into
base: 4.19
Choose a base branch
from

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes #9086

Steps to reproduce the issue

  • create an env
  • check certs in SSVM
    keytool -list -keystore /usr/local/cloud/systemvm/certs/realhostip.keystore -storepass vmops.com |grep entries
  • upgrade the env, and then patch the SSVM
  • OR, patch the SSVM forcely
  • check certs in SSVM again
    keytool -list -keystore /usr/local/cloud/systemvm/certs/realhostip.keystore -storepass vmops.com |grep entries

expect results

  • the certs are imported

actual results

  • the keystore contains only 4 certs after patching

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.10%. Comparing base (a6cef7a) to head (42ca8ed).
Report is 22 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9900      +/-   ##
============================================
- Coverage     15.11%   15.10%   -0.01%     
+ Complexity    11217    11213       -4     
============================================
  Files          5404     5404              
  Lines        473426   473426              
  Branches      60681    59665    -1016     
============================================
- Hits          71539    71523      -16     
- Misses       393891   393909      +18     
+ Partials       7996     7994       -2     
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohityadavcloud rohityadavcloud added this to the 4.19.2.0 milestone Nov 7, 2024
@weizhouapache weizhouapache marked this pull request as ready for review November 7, 2024 10:08
@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certificate error when downloading ISO (keystore not set up correctly)
5 participants