CASSANDRASC-141: Mutual TLS Authentication and Authorization to Sidecar #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch by Raymond Welgosh; Reviewed by TBD for CASSANDRASC-141
requireNonNullElse only available for java9 and up
arjunashok
reviewed
Aug 15, 2024
Comment on lines
456
to
459
| void testSidecarSpecificPermissions() | ||
| { | ||
|
|
||
| } |
There was a problem hiding this comment.
Pending/incomplete test?
arjunashok
reviewed
Aug 15, 2024
Comment on lines
607
to
615
| if (conf.authenticatorConfiguration() != null && | ||
| conf.authenticatorConfiguration().authConfig() != null && | ||
| conf.authorizerConfiguration().authConfig().equals(AuthorizerConfig.MutualTlsAuthorizer)) | ||
| { | ||
| authProvider = new MutualTlsAuthorizationProvider(permissionsAccessor); | ||
| } | ||
| else if (conf.authenticatorConfiguration() != null && | ||
| conf.authenticatorConfiguration().authConfig() != null && | ||
| conf.authorizerConfiguration().authConfig().equals(AuthorizerConfig.AllowAllAuthorizer)) |
There was a problem hiding this comment.
Checking for the wrong configuration. Should be authZ and not authN.
- This can be implemented as a switch statement over Enums instead after the initial checks. Also apply to other config providers.
- authZ provider can be served/injected by it's own provider method.
There was a problem hiding this comment.
Note: Addressed this in my most recent commit to your branch. Just has some minor refactoring of enums and defaults.
rwelgosh
force-pushed
the
CASSANDRASC-141
branch
from
b520cc3 to
6b9ec2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch by Raymond Welgosh; Reviewed by TBD for CASSANDRASC-141