Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAMEL-19834] fix camel-test-infra-elasticsearch container start fails if ca cert is not present #11302

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[CAMEL-19834] fix camel-test-infra-elasticsearch container start fails if ca cert is not present #11302

merged 1 commit into from
Sep 5, 2023

Conversation

valdar
Copy link
Member

@valdar valdar commented Sep 5, 2023

Description

fix https://issues.apache.org/jira/browse/CAMEL-19834

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@essobedo
Copy link
Contributor

essobedo commented Sep 5, 2023

Even if this change seems to make sense, are you sure that it is good enough? Have you tested it?

oscerd
oscerd approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valdar
Copy link
Member Author

valdar commented Sep 5, 2023

Even if this change seems to make sense, are you sure that it is good enough? Have you tested it?

I have tested it in camel kafka connector project as part of the update to camel 4 see: apache/camel-kafka-connector#1563 in particular apache/camel-kafka-connector@6a5054f#diff-7326dc4630c96c361c386c9fa42d76f809df68b49f7adc6e088cd55f68fd4f10

@essobedo
Copy link
Contributor

essobedo commented Sep 5, 2023

Good news, thx for letting me know 👍

@essobedo essobedo merged commit bfb160c into apache:main Sep 5, 2023
@valdar valdar deleted the CAMEL-19834 branch September 5, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@essobedo essobedo essobedo approved these changes

Assignees
No one assigned
Labels
camel-4 test-infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valdar @essobedo @oscerd