Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add observability services starter #1282

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Nov 15, 2024

In this PR we're adding the starter for the component.

@squakez squakez force-pushed the feat/csb_observability_services branch from e6b58e6 to a345737 Compare November 15, 2024 14:01
@squakez
Copy link
Contributor Author

squakez commented Nov 15, 2024

@davsclaus @Croway I've tested the component with a servlet, and the clash, although did not produce any error, really was not allowing the exposure of the metrics. Tested changing the component default, instead, makes it work:

$ curl http://localhost:8080/camel/greet
Hello World
$ curl http://localhost:8080/observe/metrics
# HELP application_ready_time_seconds Time taken for the application to be ready to service requests
# TYPE application_ready_time_seconds gauge
...

It makes sense to move the base default to /observe/, hence having /observe/metrics, /observe/health, ... I'm changing it also in the core component.

@davsclaus
Copy link
Contributor

Yes observe is a good name

And about servlet then it was before we had platform-http on SB. So its not recommended to use. But IMHO lets avoid using camel as end users may use that too.

@squakez
Copy link
Contributor Author

squakez commented Nov 18, 2024

Default changed also in core: apache/camel#16302

@squakez squakez merged commit bdc9781 into apache:main Nov 18, 2024
2 checks passed
@squakez squakez deleted the feat/csb_observability_services branch November 18, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants