Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-6658] Update Jackson from 2.15.2 to 2.15.4 in Avatica #257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Oct 31, 2024

No description provided.

@stoty
Copy link
Contributor Author

stoty commented Oct 31, 2024

This did not fail for me when testing the upgrades together.
Possibly the checkstyle update pulls in a new enough asm jar ?

@stoty
Copy link
Contributor Author

stoty commented Oct 31, 2024

should work when rebased on top of #260

@stoty
Copy link
Contributor Author

stoty commented Nov 12, 2024

Rebasing on top of #260 only does not help.
Is some other plugin forcing an asm downgrade ?

@stoty
Copy link
Contributor Author

stoty commented Nov 12, 2024

The problem is that the current asm version constraints apply to the code buing built, but they do not apply to the plugins.

Asm is only used in tests by kerby, and it doesn't seem to cause a problem, it may even be necessary, so I wouldn't touch that, but we definitely need to add the constraint for the shadow plugin.

No why it worked for me when I first tested it, probably I made some mistake.

@stoty
Copy link
Contributor Author

stoty commented Nov 12, 2024

Technically, we have two mechanisms:

  • The constraints for the project ( not build), are applied by the property reading magic.
  • We have a block for applying the constraints for the spotbug plugins only.

There is nothing that that would apply to the shadowJar plugin.

The mechanism used for overriding the constraints does not work for shadowJar plugin, but we can just add the constraint globall to the build environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant