-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIGTOP-4028 : Excluding log dependencies corresponding to hbase in the hive service #1200
base: master
Are you sure you want to change the base?
BIGTOP-4028 : Excluding log dependencies corresponding to hbase in the hive service #1200
Conversation
Why ERROR and WARN messages are not shown at all after the patch is applied? Those messages seem not to be related to multiple slf4j bindings. |
I meant the log messages related to HiveConf and FileUtils should be emitted even after fixing duplicate slf4j bindings. |
Hmm. I can not reproduce the issue by just installing both Hive and HBase. Is the issue already fixed in master (and maybe branch-3.2) by upgrading HBase? There is no slf4j-reload4j-1.7.33.jar in the output of
|
# depends on HBASE-8438 (hbase-0.94.14+, hbase-0.96.1+) for `hbase mapredcp` command | ||
for x in $($HBASE_BIN mapredcp 2>&2 | tr ':' '\n') ; do | ||
- if [[ $x == *zookeeper* || $x == *protobuf-java* || $x == *guava* ]] ; then | ||
+ if [[ $x == *zookeeper* || $x == *protobuf-java* || $x == *guava* || $x == *log* || $x == *slf4j* ]] ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*log*
looks prone to future bug by matching unintentional files. What is the target jar here?
Same to *slf4j*
. Are you really sure that all jars matching the pattern should be excluded?
…e hive service
Description of PR
Excluding log dependencies corresponding to hbase in the hive service
before:
after:
How was this patch tested?
Launch hive CLI to view startup logs
For code changes: