-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIGTOP-3959: RPM packaging for TRINO #1157
base: master
Are you sure you want to change the base?
Conversation
1bea5e0
to
d62d8e7
Compare
@Akanksha-kedia Before addressing review comments, please send |
@Akanksha-kedia, I think I am not the person you want to ask for the assignment. I'm another masatake. |
Hey @Akanksha-kedia do you want the JIRA or this GH issue assigned to you? Or both? |
Both
…On Fri, 11 Aug 2023 at 5:18 PM, Roman V Shaposhnik ***@***.***> wrote:
Hey @Akanksha-kedia <https://github.com/Akanksha-kedia> do you want the
JIRA or this GH issue assigned to you? Or both?
—
Reply to this email directly, view it on GitHub
<#1157 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVL2AZRXY5P35XPRM5LRORLXUYL2HANCNFSM6AAAAAA3CP4UEI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Done! |
@Akanksha-kedia Half a year has passed, this PR seems inactive with no progress. Do you still want to continue working on the task of adding Trino support to Bigtop? If you have abandoned this PR due to lack of time or other reasons, please let me know. I would like to move this work forward and complete it as soon as possible. |
Yes, I am working on it.but it seemed community was not willing to add
trino as a new stack
…On Fri, 1 Mar 2024 at 7:04 AM, jialiang ***@***.***> wrote:
@Akanksha-kedia <https://github.com/Akanksha-kedia> Half a year has
passed, this PR seems inactive with no progress. Do you still want to
continue working on the task of adding Trino support to Bigtop? If you have
abandoned this PR due to lack of time or other reasons, please let me know.
I would like to move this work forward and complete it as soon as possible.
—
Reply to this email directly, view it on GitHub
<#1157 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVL2AZWCKNP7WRLK364X7DLYV7LJZAVCNFSM6AAAAAA3CP4UEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZSGI4DMMJVHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@Akanksha-kedia In this RP, community members are actively helping with reviews and providing feedback. Please continue to drive this PR based on the review feedback. If you wish to abandon this PR, you can close it, and I will take over. |
Thanks i ll try completing
…On Sat, 2 Mar 2024 at 11:26 AM, jialiang ***@***.***> wrote:
@Akanksha-kedia <https://github.com/Akanksha-kedia> In this RP, community
members are actively helping with reviews and providing feedback. Please
continue to drive this PR based on the review feedback. If you wish to
abandon this PR, you can close it, and I will take over.
—
Reply to this email directly, view it on GitHub
<#1157 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVL2AZTLTMHWFLJK62OKH4DYWFSYFAVCNFSM6AAAAAA3CP4UEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZUGMZTAOBXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@JiaLiangC hello, can you please help me to test the pr as some limitation i have in my system, u can give co author or i can assign u as well, its a collaborative work i m asking for.? |
@Akanksha-kedia |
@JiaLiangC Thank you for your contributions and for thoroughly testing the changes in your environment. I appreciate your dedication and commitment to this project. I have followed the steps to grant you write access to the repository. You should receive an invitation to collaborate shortly. Once you accept the invitation, you will be able to push your modifications to the branch. Looking forward to our continued collaboration on this project! it would be good if u add the test report and steps. in this. |
@Akanksha-kedia |
Can we review and get this merged @JiaLiangC |
@JiaLiangC @iwasakims @rvs can you help to review. |
@Akanksha-kedia I don't have cycle to review this now since I'm working on 3.3.0 release. Please wait or find another supporter. |
BIGTOP-3959
Add trino as a component in Bigtop
Bring Trino into Bigtop to deploy and manage trino through Ambari
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
Gradle : 5.6.4
Trino : jdk 17
Trino : master(https://github.com/trinodb/trino)
https://trino.io/docs/current/installation/deployment.html
cmd :
Path for rpm : bigtop/build/trino/rpm/RPMS/noarch
bigtop/dl/trino.tar.gz (tarball) Downloaded trino code as tarball and placed under the path mentioned.
rpm2cpio trino-415-1.el7.noarch.rpm | cpio -idmv