-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45402: [CI][Dev][Ruby] Reformat codes before apply lint #45403
base: main
Are you sure you want to change the base?
Conversation
|
system ENV.cxx, "test.cpp", "-std=c++17", "-I#{include}", "-L#{lib}", | ||
"-larrow", "-o", "test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you exclude this from lint targets?
This is a vendored file. Upstream is https://github.com/Homebrew/homebrew-core/blob/master/Formula/a/apache-arrow.rb .
BTW, we should resync this and apache-arrow-glib.rb
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted this change and add the exclude section in the .pre-commit-config.yaml
( A PR of .pre-commit-config.yaml
will create later.)
exclude: >-
(
?^dev/tasks/homebrew-formulae/.*\.rb$|
)
Note
- I will check
apache-arrow-glib.rb
on anther PR. - Is this typo?
dev/tasks/homebrew-formulae
(formulae
->formula
)
Rationale for this change
#45398 will apply Ruby lint. Before this change, some code needs to be reformatted to avoid format errors.
What changes are included in this PR?
Reformat Ruby codes.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.