GH-39023: [C++][CMake] Add missing launcher path conversion for ExternalPackage #45349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
wgtmac
approved these changes
Jan 25, 2025
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2c90daf. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them. |
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Jan 30, 2025
… ExternalPackage (apache#45349) ### Rationale for this change We need to convert it on Windows. ### What changes are included in this PR? Convert it to CMake path. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#39023 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We need to convert it on Windows.
What changes are included in this PR?
Convert it to CMake path.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.