GH-45195: [C++] Update bundled AWS SDK for C++ to 1.11.489 #45306

kou · 2025-01-20T08:31:00Z

Rationale for this change

The current bundled version 1.10.55 was released on 2023-01-20:
https://github.com/aws/aws-sdk-cpp/releases/tag/1.10.55

What changes are included in this PR?

Use the latest AWS SDK for C++
Migrate to FetchContent from ExternalProject

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

GitHub Issue: [C++] Update bundled AWS SDK for C++ from 1.10.55 #45195

kou · 2025-01-20T08:31:22Z

@github-actions crossbow submit -g cpp -g r

github-actions · 2025-01-20T08:31:25Z

⚠️ GitHub issue #45195 has been automatically assigned in GitHub to PR creator.

h-vetinari · 2025-01-20T08:49:38Z

From the POV of the update for #45195, please don't go past 1.1.458 for now, see #45304

kou · 2025-01-20T09:12:54Z

Thanks for the tip! I saw your comment in #45195 but I wanted to try the latest version as the first try. :-)

please don't go past 1.1.458 for now

It's 1."10".458, right?

h-vetinari · 2025-01-20T09:23:21Z

please don't go past 1.1.458 for now

It's 1."10".458, right?

Sorry for the typo, it's 1."11".458

h-vetinari · 2025-01-23T09:57:10Z

cpp/thirdparty/versions.txt

+ARROW_AWS_CRT_CPP_BUILD_SHA256_CHECKSUM=d445ab7a26c03a0c0cbb9d82203ee32a56c762a3cef1874783783431b8eb015a
+ARROW_AWS_LC_BUILD_VERSION=v1.42.0
+ARROW_AWS_LC_BUILD_SHA256_CHECKSUM=8537025ebfd3884830f494166ae5f72f8aaa203d49abe650a0560a7ffedf359e
+ARROW_AWSSDK_BUILD_VERSION=1.11.489


PR title needs an update; 1.11.488 -> 1.11.489 ;-)

Good catch!

kou · 2025-01-27T07:22:22Z

@github-actions crossbow submit -g cpp -g wheel -g r -g linux

github-actions · 2025-01-27T07:27:43Z

Revision: 8c751c0

Submitted crossbow builds: ursacomputing/crossbow @ actions-7a18e3917f

Task	Status
almalinux-8-amd64
almalinux-8-arm64
almalinux-9-amd64
almalinux-9-arm64
amazon-linux-2023-amd64
amazon-linux-2023-arm64
centos-7-amd64
centos-8-stream-amd64
centos-8-stream-arm64
centos-9-stream-amd64
centos-9-stream-arm64
debian-bookworm-amd64
debian-bookworm-arm64
debian-trixie-amd64
debian-trixie-arm64
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
python-sdist
r-binary-packages
r-recheck-most
test-alpine-linux-cpp
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp-ubuntu-20.04-cuda-11.2.2
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-fedora-39-cpp
test-r-arrow-backwards-compatibility
test-r-clang-sanitizer
test-r-depsource-bundled
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-valgrind
test-r-macos-as-cran
test-r-minimal-build
test-r-offline-maximal
test-r-offline-minimal
test-r-rhub-debian-gcc-devel-lto-latest
test-r-rhub-debian-gcc-release-custom-ccache
test-r-rhub-ubuntu-release-latest
test-r-rocker-r-ver-latest
test-r-rstudio-r-base-4.1-opensuse155
test-r-rstudio-r-base-4.2-focal
test-r-ubuntu-22.04
test-r-versions
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-bundled
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer
test-ubuntu-r-sanitizer
ubuntu-focal-amd64
ubuntu-focal-arm64
ubuntu-jammy-amd64
ubuntu-jammy-arm64
ubuntu-noble-amd64
ubuntu-noble-arm64
wheel-macos-monterey-cp310-cp310-amd64
wheel-macos-monterey-cp310-cp310-arm64
wheel-macos-monterey-cp311-cp311-amd64
wheel-macos-monterey-cp311-cp311-arm64
wheel-macos-monterey-cp312-cp312-amd64
wheel-macos-monterey-cp312-cp312-arm64
wheel-macos-monterey-cp313-cp313-amd64
wheel-macos-monterey-cp313-cp313-arm64
wheel-macos-monterey-cp313-cp313t-amd64
wheel-macos-monterey-cp313-cp313t-arm64
wheel-macos-monterey-cp39-cp39-amd64
wheel-macos-monterey-cp39-cp39-arm64
wheel-manylinux-2-28-cp310-cp310-amd64
wheel-manylinux-2-28-cp310-cp310-arm64
wheel-manylinux-2-28-cp311-cp311-amd64
wheel-manylinux-2-28-cp311-cp311-arm64
wheel-manylinux-2-28-cp312-cp312-amd64
wheel-manylinux-2-28-cp312-cp312-arm64
wheel-manylinux-2-28-cp313-cp313-amd64
wheel-manylinux-2-28-cp313-cp313-arm64
wheel-manylinux-2-28-cp313-cp313t-amd64
wheel-manylinux-2-28-cp313-cp313t-arm64
wheel-manylinux-2-28-cp39-cp39-amd64
wheel-manylinux-2-28-cp39-cp39-arm64
wheel-manylinux-2014-cp310-cp310-amd64
wheel-manylinux-2014-cp310-cp310-arm64
wheel-manylinux-2014-cp311-cp311-amd64
wheel-manylinux-2014-cp311-cp311-arm64
wheel-manylinux-2014-cp312-cp312-amd64
wheel-manylinux-2014-cp312-cp312-arm64
wheel-manylinux-2014-cp313-cp313-amd64
wheel-manylinux-2014-cp313-cp313-arm64
wheel-manylinux-2014-cp313-cp313t-amd64
wheel-manylinux-2014-cp313-cp313t-arm64
wheel-manylinux-2014-cp39-cp39-amd64
wheel-manylinux-2014-cp39-cp39-arm64
wheel-windows-cp310-cp310-amd64
wheel-windows-cp311-cp311-amd64
wheel-windows-cp312-cp312-amd64
wheel-windows-cp313-cp313-amd64
wheel-windows-cp313-cp313t-amd64
wheel-windows-cp39-cp39-amd64

kou · 2025-01-27T08:08:18Z

@github-actions crossbow submit ubuntu-jammy-amd64

github-actions · 2025-01-27T08:10:30Z

Revision: 061a9a1

Submitted crossbow builds: ursacomputing/crossbow @ actions-1adf04401b

Task	Status
ubuntu-jammy-amd64

pitrou · 2025-01-27T16:49:36Z

cpp/thirdparty/README.md

+the latest version automatically. You can use it like the following:
+
+```console
+dev/release/update.rb PRODUCT_PATTERN1 PRODUCT_PATTERN2 ...


This is neat, but the path doesn't look right, should be cpp/thirdparty/update.rb?

Oh... Good catch! You're right.

pitrou · 2025-01-27T16:50:50Z

cpp/thirdparty/update.rb

+versions_txt = File.join(__dir__, "versions.txt")
+versions_txt_content = File.read(versions_txt)
+products = parse_versions_txt_content(versions_txt_content)
+ARGV.each do |pattern|


Is it possible to have a -h/--help option to display usage?

Yes. I'll add it.

kou · 2025-01-28T20:13:05Z

@github-actions crossbow submit r-binary-packages

github-actions · 2025-01-28T20:15:20Z

Revision: a090a31

Submitted crossbow builds: ursacomputing/crossbow @ actions-a889add4dd

Task	Status
r-binary-packages

kou · 2025-01-30T06:30:00Z

@github-actions crossbow submit test-ubuntu-24.04-cpp-thread-sanitizer

github-actions · 2025-01-30T06:32:09Z

Revision: 5a74a08

Submitted crossbow builds: ursacomputing/crossbow @ actions-fb5d3fd0fa

Task	Status
test-ubuntu-24.04-cpp-thread-sanitizer

kou · 2025-01-30T06:44:30Z

cpp/cmake_modules/aws-crt-cpp.diff

I want to remove all .diffs by upstreaming all changes so that we don't need patch in build environment.

github-actions bot added Component: C++ awaiting committer review Awaiting committer review labels Jan 20, 2025

This comment was marked as outdated.

Sign in to view

kou force-pushed the cpp-bundled-aws-sdk-cpp branch from f0dcc60 to b41b663 Compare January 22, 2025 00:54

github-actions bot added the Component: Documentation label Jan 22, 2025

h-vetinari reviewed Jan 23, 2025

View reviewed changes

kou changed the title ~~GH-45195: [C++] Update bundled AWS SDK for C++ to 1.11.488~~ GH-45195: [C++] Update bundled AWS SDK for C++ to 1.11.489 Jan 23, 2025

github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting committer review Awaiting committer review awaiting changes Awaiting changes labels Jan 23, 2025

kou mentioned this pull request Jan 27, 2025

[R] Can we bump MACOSX_DEPLOYMENT_TARGET from 10.13? #45356

Closed

pitrou reviewed Jan 27, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Jan 27, 2025

kou force-pushed the cpp-bundled-aws-sdk-cpp branch from fbcb205 to a090a31 Compare January 28, 2025 20:11

kou mentioned this pull request Jan 30, 2025

GH-44950: [C++] Bump minimum CMake version to 3.25 #44989

Open

kou commented Jan 30, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jan 30, 2025

kou added 19 commits January 31, 2025 10:35

apacheGH-45195: [C++] Update bundled AWS SDK for C++ to 1.11.488

e78507a

Add missing diff

bcaa292

Fix variable name

a8b116e

Update versions

0f4db75

Use aws-lc to intern symbols in s2n-tls

7f0c17a

Disable needless components

d407215

Add workaround for s2n-tls

7c206d5

Use remove for old CMake

a05e575

Link s2n_libcrypto.a

eafca38

Fix s2n-tls

0caec4e

Don't use OpenSSL

780af4e

Add a missing license header

9b23e6f

Don't use aws-lc

5f2fb91

Fix

b552ccb

Disable LTO

fa51d6f

Add support for -h

73a37b7

Fix path

be9f9a7

Use SYSTEM

2e8decf

Use OVERRIDE_FIND_PACKAGE

93ffaee

kou force-pushed the cpp-bundled-aws-sdk-cpp branch from 5a74a08 to 93ffaee Compare January 31, 2025 02:00

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-45195: [C++] Update bundled AWS SDK for C++ to 1.11.489 #45306

GH-45195: [C++] Update bundled AWS SDK for C++ to 1.11.489 #45306

kou commented Jan 20, 2025 •

edited by github-actions bot

Loading

kou commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

This comment was marked as outdated.

h-vetinari commented Jan 20, 2025

kou commented Jan 20, 2025

h-vetinari commented Jan 20, 2025

h-vetinari Jan 23, 2025

kou Jan 23, 2025

kou commented Jan 27, 2025

github-actions bot commented Jan 27, 2025

kou commented Jan 27, 2025

github-actions bot commented Jan 27, 2025

pitrou Jan 27, 2025

kou Jan 27, 2025

pitrou Jan 27, 2025

kou Jan 27, 2025

kou commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

kou commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

kou Jan 30, 2025

GH-45195: [C++] Update bundled AWS SDK for C++ to 1.11.489 #45306

Are you sure you want to change the base?

GH-45195: [C++] Update bundled AWS SDK for C++ to 1.11.489 #45306

Conversation

kou commented Jan 20, 2025 • edited by github-actions bot Loading

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

kou commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

This comment was marked as outdated.

h-vetinari commented Jan 20, 2025

kou commented Jan 20, 2025

h-vetinari commented Jan 20, 2025

h-vetinari Jan 23, 2025

Choose a reason for hiding this comment

kou Jan 23, 2025

Choose a reason for hiding this comment

kou commented Jan 27, 2025

github-actions bot commented Jan 27, 2025

kou commented Jan 27, 2025

github-actions bot commented Jan 27, 2025

pitrou Jan 27, 2025

Choose a reason for hiding this comment

kou Jan 27, 2025

Choose a reason for hiding this comment

pitrou Jan 27, 2025

Choose a reason for hiding this comment

kou Jan 27, 2025

Choose a reason for hiding this comment

kou commented Jan 28, 2025

github-actions bot commented Jan 28, 2025

kou commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

kou Jan 30, 2025

Choose a reason for hiding this comment

kou commented Jan 20, 2025 •

edited by github-actions bot

Loading