Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always explicitly disable
gzip
automatic decompression on reqwest client used by object_store #6843Always explicitly disable
gzip
automatic decompression on reqwest client used by object_store #6843Changes from all commits
d495259
9aac025
796f399
3152693
e2f8c2e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean that gzipped data content will be left gzipped?
So if I request a resource that the server gzip's in response, that the result I get from
ObjectStore::get
would also be gzipped 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is correct - sorry I could have made this clearer.
All this affects is what happens when the response has the header
Content-Encoding: gzip
, which HTTP servers will usually only do when the request has the headerAccept-Encoding: gzip
. If that is the case, then reqwest will transparently decode the body as a gzip stream and remove theContent-Length
header (if thegzip
feature is enabled - thisno_gzip
function explicitly disables that behavior even if the feature is)For object store APIs, it will just return the bytes of the object as they are (including objects that are gzipped).