Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad_data::test_invalid_files fails during release verification #6343

Open
alamb opened this issue Aug 31, 2024 · 1 comment
Open

bad_data::test_invalid_files fails during release verification #6343

alamb opened this issue Aug 31, 2024 · 1 comment
Labels

Comments

@alamb
Copy link
Contributor

alamb commented Aug 31, 2024

Describe the bug

While working on #6016 the release verification script fails like this:

---- bad_data::test_invalid_files stdout ----
thread 'bad_data::test_invalid_files' panicked at parquet/./tests/arrow_reader/bad_data.rs:64:9:
Found new file in bad_data, please add test: ARROW-GH-43605.parquet
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

failures:
    bad_data::test_invalid_files

test result: FAILED. 51 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.75s

error: test failed, to rerun pass `-p parquet --test arrow_reader`
+ cleanup
+ '[' no = yes ']'
+ echo 'Failed to verify release candidate. See /var/folders/1l/tg68jc6550gg8xqf1hr4mlwr0000gn/T/arrow-53.0.0.XXXXX.Gs46gX0sT4 for de

To Reproduce

Expected behavior
Test should pass

Additional context

@alamb alamb added the bug label Aug 31, 2024
@alamb
Copy link
Contributor Author

alamb commented Aug 31, 2024

The issue appears to be that I was too clever in the tests -- they look for invalid files that are not added to the tests

THey don't fail on CI as the master branch has a pinned submodule, but the verification scripts just checkout whatever is at the head:

# Clone testing repositories if not cloned already
git clone https://github.com/apache/arrow-testing.git arrow-testing-data
git clone https://github.com/apache/parquet-testing.git parquet-testing-data

I'll put in a workaround to get 53.0.0 out the door, but then we'll have to fix it for real subsequently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant