-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Add StringView and BinaryView IO to Python bindings #637
Conversation
@WillAyd If you have bandwidth, this could use a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I only have really minor comments
and i == (2 + self._ptr.n_variadic_buffers) | ||
): | ||
return ( | ||
NANOARROW_BUFFER_TYPE_DATA, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking the type of the variadic buffer is actually missing from the C++ test; we might want to go back and add this there too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll follow this up with a C library PR!
Co-authored-by: William Ayd <[email protected]>
Co-authored-by: William Ayd <[email protected]>
This PR implements StringView support in the Python bindings. It is a thin wrapper around the C functions added, although we should perhaps abstract some of the buffer info calculation into the C library since I had to work around that in the R bindings as well.