Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update reusability of some parameters, update versions of ingr… #770

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ikatlinsky
Copy link
Contributor

This pull request addresses 2 cases:

  1. Updating some of the configuration options to be rendered through the tpl directive, which is needed to improve configurability and reusability of the parameters when the values file is composed. Ideally all parameters should be migrated to this approach to make it more consistent and predictable.
    For example:

Ingress

  ingress:
    enabled: true
    annotations: 
      kubernetes.io/ingress.class: nginx 
    hosts:
      - host: "{{ tpl .Values.global.app.host . }}"
        paths:
          - "/"
    tls:
      - secretName: "{{ tpl .Values.global.config.secrets.tlsSecret . }}"
        hosts:
          - "{{ tpl .Values.global.app.host . }}"

External etcd

  externalEtcd:
    host:
      - "http://{{ tpl .Values.global.app.etcdHost . }}:2379"
    prefix: "/apisix"
    user: ""
  1. Updating the version of the dashboard and ingress controller images to the latest versions

@ikatlinsky
Copy link
Contributor Author

@Gallardot @AlinsRan please review

@ikatlinsky
Copy link
Contributor Author

@Gallardot @AlinsRan sorry for pinging, can you please check PR

@Gallardot
Copy link
Member

@Revolyssup @shreemaan-abhishek PTAL.

@ikatlinsky
Copy link
Contributor Author

@Revolyssup @shreemaan-abhishek up

1 similar comment
@ikatlinsky
Copy link
Contributor Author

@Revolyssup @shreemaan-abhishek up

@ikatlinsky
Copy link
Contributor Author

@ikatlinsky
Copy link
Contributor Author

1 similar comment
@ikatlinsky
Copy link
Contributor Author

Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikatlinsky
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants