Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to apisix 3.9.1 and enable etcd port in ingress-controller if using etcd adapter #761

Closed
wants to merge 4 commits into from

Conversation

gamer22026
Copy link

Updates ingress-controller to use apisix 3.9.1 as control plane when using etcd-adapter.
Updates ingress controller version to latest 1.8.2
Enables ingress controller service to listen on port 12379 if etcd adapter is enabled.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service change is unnecessary, as the container is embedded in the same pod/network namespace. This change exposes the insecure port to the rest of the cluster, which is not what you want.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to implement the architecture diagrammed here: https://static.apiseven.com/apisix-webp/uploads/2023/10/24/UbKWYGar_APISIX-Ingress-4.webp but what I ended up with using the latest helm chart was the ingress controller/with embedded apisix running as the control plane, and a separate pod cluster running apisix as the data plane. (which is why I was exposing the service port so the apisix pods running the data plane had an etcd to connect to). Is there something I missed in the helm config to get the ingress controllers to embed both the apisix control plane and the data plane together as the diagram shows?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The composite architecture using the same pod has been implemented for a while. Your current changes doesn't have a separate pod running apisix, AFAICT. Using a separate pod is problematic anyway, as it means that you have to reinvent security between etcd and apisix.

@Revolyssup
Copy link
Contributor

@gamer22026 Can you fix the CI?

@gamer22026 gamer22026 closed this Jul 23, 2024
@gamer22026 gamer22026 deleted the update-to-apisix-3.9.0 branch July 23, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants